Updated cdc import script to write nodes to a specified DCP instance#476
Updated cdc import script to write nodes to a specified DCP instance#476dwnoble merged 8 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @dwnoble, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements functionality to write nodes to a Data Commons Platform instance by converting RDF triples to JSON-LD, with a sound approach and commendable unit tests. However, a security audit identified a high-severity Server-Side Request Forgery (SSRF) vulnerability due to unvalidated request URLs constructed from environment variables, which could allow arbitrary requests. This is compounded by a medium-severity Information Disclosure vulnerability, as full HTTP responses are logged, potentially exposing sensitive data if SSRF is exploited. Additionally, a high-severity bug in an exception handler could lead to a crash, and there are suggestions for improving maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ort into dcp-import-nodes
clincoln8
left a comment
There was a problem hiding this comment.
Thanks Dan! Just a few nonblocking conceptual questions. We can chat about them in our next sync too.
Implements insert_triples in DataCommonsPlatformDb to enable node ingestion via the /nodes endpoint.
Next steps:
Tested using these instructions: https://docs.google.com/document/d/1nVybHja5BJcSxj4k0bbZCe9a2TeR9iU4wmTftAfxdVc/edit?resourcekey=0-GtDvvc1uqBULO7fzVDd-rA&tab=t.f27b3lcg6zg3