fix: added ui auth rules to the backend model#310
Open
saptarshi-datazip wants to merge 4 commits intodatazip-inc:stagingfrom
Open
fix: added ui auth rules to the backend model#310saptarshi-datazip wants to merge 4 commits intodatazip-inc:stagingfrom
saptarshi-datazip wants to merge 4 commits intodatazip-inc:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the authentication rules (like password needs to be 6 char length). This doesnot allow user to create credentials that fails in the UI.
If this is breaking maybe we can restore the backend and remove the checks in the frontend ui. ( like if some old user created credentials using curl command and logins using that. it will now fail as the backend will only not allow the login)
Fixes #303
Type of change
How Has This Been Tested?
Ran with and without the changes and checked the edge case of 6 length password.
Not explicitly tested for username length and other conditions.
Screenshots or Recordings
Before changes:
After changes:
Related PR's (If Any):