fix: fallback version in air-gapped environments#341
Open
yangbooom wants to merge 1 commit intodatazip-inc:masterfrom
Open
fix: fallback version in air-gapped environments#341yangbooom wants to merge 1 commit intodatazip-inc:masterfrom
yangbooom wants to merge 1 commit intodatazip-inc:masterfrom
Conversation
When the BFF server cannot reach Docker Hub / GitHub to fetch connector versions, source and destination creation was completely blocked because the version dropdown stayed empty and validation rejected empty versions. Server changes: - GetSourceVersions: return DefaultSpecVersion on fetch failure instead of error - GetDestinationVersions: same fallback behavior - Log warning instead of failing hard Frontend changes: - CreateSource.tsx: use 'latest' fallback on version fetch error - CreateDestination.tsx: same fallback behavior Fixes datazip-inc#340
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Source and destination creation is completely blocked in air-gapped / private-network deployments because the version dropdown stays empty when Docker Hub / GitHub is unreachable.
Root cause:
GetSourceVersionsandGetDestinationVersionsreturn hard errors whenGetDriverImageTagsfails, and the frontend'svalidateSource()rejects empty versions with"No versions available".Fixes #340
Changes
Server (
server/internal/services/etl/)source.go—GetSourceVersions: returnDefaultSpecVersionas fallback instead of errordestination.go—GetDestinationVersions: same fallback behaviorFrontend (
ui/src/modules/)CreateSource.tsx— catch block usesinitialVersion || "v0.2.0"fallback instead ofresetVersionState()CreateDestination.tsx— same fallbackBehavior
Double-layer defense: even if only one side is updated, the fix works.
Testing
validateSource()accepts fallback version and proceeds to next step