Skip to content

chore: make catalog_name required and add s3_path_style to rest catalog #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishalm0509 wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

chore: make catalog_name required and add s3_path_style to rest catalog #919

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
577513a
chore: make catalog_name required and add s3_path_style to rest catalog
vishalm0509 Apr 14, 2026
5b761d3
Merge branch 'staging' of https://github.com/datazip-inc/olake into c…
vishalm0509 Apr 15, 2026
9a9dc3e
chore: remove catalog_name from required and add default value
vishalm0509 Apr 15, 2026
8a3b5ec
Merge branch 'staging' into chore/spec_changes
vishalm0509 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions destination/iceberg/resources/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"type": "string",
"title": "Catalog Name",
"pattern": "^[a-z_]+$",
"default": "olake_iceberg",
"description": "User defined catalog name, if left blank defaults to olake_iceberg. Only lowercase letters and underscores are allowed."
},
"arrow_writes": {
Expand Down Expand Up @@ -214,6 +215,12 @@
"type": "string",
"title": "S3 Endpoint",
"description": "Specifies the endpoint URL for S3 compatible services (e.g., MinIO)"
},
"s3_path_style": {
"type": "boolean",
"default": false,
"title": "Use Path Style for S3",
"description": "Enables path-style addressing for S3 API requests"
}
},
"required": [
Expand Down
Loading