commiting fixes for pull request#1
Open
jerowe wants to merge 1 commit intodavek44:masterfrom
jerowe:master
Open
commiting fixes for pull request#1jerowe wants to merge 1 commit intodavek44:masterfrom jerowe:master
jerowe wants to merge 1 commit intodavek44:masterfrom
jerowe:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great tool!
I've made a few changes I hope you will incorporate into the main repo.
Mostly, I want to change filepaths being hardcoded in the script. All necessary executables should be available in the PATH environmental variable.
For instance, when running quake.py, I should already have
baseapp/quake/bin/quake.py,correct,count-qmers in the PATH var.
By the same token I already have jellyfish in my path. There is no need to create an additional install step where jellyfish and the libraries need to have a symbolic link to the quake bin.