Dependency maintenance#701
Open
andersstorhaug wants to merge 1 commit intodavid-driscoll:masterfrom
Open
Conversation
805fcb6 to
be8f963
Compare
Author
|
As for the Mergify error, I'm not familiar at all but I did find this blog post. It seems the equivalent queue_rules:
- name: default
method: squash
conditions: []
pull_request_rules:
- name: automatic merge when GitHub branch protection passes (others)
conditions:
- base=master
- -author~=^dependabot(|-preview)\[bot\]$
- 'label=:shipit: merge'
actions:
queue:
name: default
- name: auto merge github-actions
conditions:
- 'label=github-actions'
- author~=^dependabot(|-preview)\[bot\]$
actions:
label:
add:
- ':shipit: merge'
- name: automatic merge when GitHub branch protection passes
conditions:
- merged
- 'label=:shipit: merge'
actions:
label:
remove:
- ':shipit: merge'
- name: delete head branch after merge
conditions:
- merged
actions:
label:
remove:
- ':shipit: merge'
delete_head_branch: {}
|
- Upgrading packages, most notably `rxjs` to v7 - Removing unused packages: `tsdx`, `@vue/reactivity`, `@types/webpack` - Replacing compromised `faker` package with `@faker-js/faker` fork
be8f963 to
a715834
Compare
Author
|
@david-driscoll Sorry to @ you, a lot of bot-initiated PRs here so wanted to make sure that you were aware. Any thoughts on reviving this project? I like what has been done here, and perhaps we can get the ball rolling again. Thought that bringing dependencies up to date, esp. with RxJS v7, would be a good start. |
andersstorhaug
commented
Feb 7, 2022
| globals: { | ||
| 'ts-jest': { | ||
| compiler: 'typescript', | ||
| tsConfig: { |
Author
There was a problem hiding this comment.
This casing produces a warning with newer versions of Jest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
rxjsto v7tsdx,@vue/reactivity,@types/webpack,cross-envtsdxspecifically now that it's unmaintained, it was constraining package versionsfakerpackage with@faker-js/fakerforkSome other notes:
catcherrors are typed asany(which makes some sense), soDynamicDataErrorreflects thistoPromiseoperator has been replaced withlastValueFrom, see RxJS docsisScheduler, and so, this function has effectively been pulled intoexpireAfter.tshuskyhave a somewhat long-standing issue with Git GUIs, and I had to bypass commit hooks. I'm not sure if this was a problem before