Firefox Port and Version Increase from 0.4.6 --> 0.4.7#29
Open
that-gai-gai wants to merge 3 commits into
Open
Conversation
A quick port to Firefox. Updated Manifest and Readme.
Accidentally changed from HTML to Text insert
Ensured parity between version increase in both the manifest.json and about.html files
Owner
|
Thanks for this! It looks like you've modified the minified tippy library. Is this just a new version (if so, which?), or did you make other changes to it? Do you have a link to the original source? I understand that submission to the mozilla add-ons store requires the actual unminified source to be available for review, with correct version numbers and links (https://extensionworkshop.com/documentation/publish/third-party-library-usage/), so I think there are a few further changes necessary (or at least details to be researched) for a number of libraries before I can actually submit this for signing. |
Author
|
I am just now seeing this...I'll double check about the versioning and get back with you this weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ported over the extension to firefox and it is working fine. I had to change some things in tippy.min.js. My suggestion is to test on chrome on your side to ensure functionality remains unharmed.