DRAFT: Win98 Theming#781
Open
desttinghim wants to merge 3 commits into
Open
Conversation
Owner
|
Thank you very much! I've gone through once looking at the things you had to do, will have to go through again more seriously trying to list here the kinds of things required. |
|
Ha, this is pretty cool actually. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has hackily implemented more of the Win98 style. The dvui Win98 theme does not match actual Win98 styles very closely. Part of the reason for this is that dvui's theming system is not currently featureful enough to enable it. The code in this branch is something of an exploration to figure out how theming will need to be expanded on. That is to say it may be useful for reference, but it will probably be replaced by deeper changes to the theming system before being merged.