feat: Support serde_json's arbitrary_precision feature#102
Open
jpmckinney wants to merge 1 commit intodavidhewitt:mainfrom
Open
feat: Support serde_json's arbitrary_precision feature#102jpmckinney wants to merge 1 commit intodavidhewitt:mainfrom
jpmckinney wants to merge 1 commit intodavidhewitt:mainfrom
Conversation
jpmckinney
force-pushed
the
arbitrary_precision
branch
from
0b81c56 to
e5b3249
Compare
jpmckinney
force-pushed
the
arbitrary_precision
branch
from
e5b3249 to
ed9f9f8
Compare
jpmckinney
force-pushed
the
arbitrary_precision
branch
2 times, most recently
from
9adbd9e to
7559198
Compare
jpmckinney
force-pushed
the
arbitrary_precision
branch
from
7559198 to
ca3cf02
Compare
davidhewitt
reviewed
Feb 17, 2026
Owner
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for this, and sorry for the very slow review.
Seems like this is the right approach to handle this case. Ouch.
Can you please add:
- CHANGELOG entry
- Note of this feature in the README (maybe in a new
# Featuressection) - Adjust CI to run both with and without this feature enabled
... and then let's get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #101
I'm not sure of your preferences with respect to errors and tests. I think the errors are unreachable unless a user specially crafts JSON that uses
$serde_json::private::Number(which is an issue that has been reported to serde-json).Edit: I force-pushed a new commit. Original commit would convert large JSON integers to floats.