Dynamic shops v2 Electric Boogaloo#425
Open
TheDanDLion wants to merge 24 commits intodaviscook477:masterfrom
Open
Dynamic shops v2 Electric Boogaloo#425TheDanDLion wants to merge 24 commits intodaviscook477:masterfrom
TheDanDLion wants to merge 24 commits intodaviscook477:masterfrom
Conversation
…ore relic or store potion
…w, fixing the addItem static method
Author
|
i forgot this existed, so i released it as a standalone API, with sts 2 coming up id rather put something big like this on its own |
Author
|
someone in the community expressed interest in getting this in basemod so if possible let's give it another go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alright round 2, this time i made sure that it's compatible with SpicyShops, with the only issue being some spicy relic effects being rendered on other pages of the ShopGrid, so GK technically doesn't need to do anything, but other mods that choose to use the grid would have that minor annoyance
the only mod I found in my testing that had some spacing issues was HugYou's BlueThread relic from HugYouRelics, which adds 2 extra items to the shop with some overlap. as a workaround though, I added some commands for manipulating the grid, so if you do
shop add page 0it adds an empty page to help with overlap issues