Run main-based mobench fixtures on low-end devices by dcbuild3r · Pull Request #2 · dcbuild3r/provekit

dcbuild3r · 2026-04-29T14:10:05Z

Summary

port the three-fixture mobench CI run onto the main-based mobench integration branch
run passport, OPRF, and p256_bigcurve prove benchmarks by default
use low-end smoke devices for the requested run: iPhone 7 and Vivo Y21
refresh OPRF and p256 embedded artifacts so they deserialize under main's Noir beta.19 crates

Validation

cargo metadata --no-deps --format-version 1
cargo check -p bench-mobile
cargo test -p bench-mobile --test examples_smoke
cargo test -p bench-mobile --test passport_smoke
actionlint .github/workflows/mobile-bench.yml .github/workflows/mobile-bench-pr-auto.yml .github/workflows/mobile-bench-pr-command.yml .github/workflows/mobile-bench-reusable.yml
git diff --check

Not measured yet

live BrowserStack numbers will be posted by the dispatched Mobile Benchmarks workflow.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5caecc0cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-29T14:16:58Z

    let r_point = Secp256r1::evaluate_linear_expression([gen, public], [s_g, s_p], []);

-    assert(!r_point.is_infinity);
    assert(r_point.x == r_x);


Reinstate full p256 verification constraints in benchmark circuit

This change weakens the p256 fixture circuit by dropping the prior r_point validity assertions and leaving only assert(r_point.x == r_x). Because the benchmark artifact is compiled from this program, mobench now measures a less-constrained circuit than before, so reported prove times are no longer comparable to the previous “full-check” fixture and can understate real verification workload.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-29T14:16:58Z

-            2>/dev/null | head -1)
+          comments_json="$(mktemp)"
+          if gh api "repos/${REPO}/issues/${PR_NUMBER}/comments" > "${comments_json}"; then
+            EXISTING_COMMENT_ID=$(jq -r --arg marker "${MARKER}" '.[] | select(.body | contains($marker)) | .id' "${comments_json}" | head -1)


Replace jq|head pipeline in strict mode comment lookup

With set -euo pipefail enabled in this step, jq ... | head -1 can fail the script when head exits after the first match and jq receives SIGPIPE while still writing, which aborts sticky-comment handling instead of falling back to the warning paths. This is most likely when multiple marker-matching comments exist or the response is large; selecting the first ID inside jq avoids the pipeline failure mode.

Useful? React with 👍 / 👎.

dcbuild3r · 2026-04-29T17:14:25Z

Mobench BrowserStack smoke

Run: 25119169378
PR: dcbuild3r/provekit#2
Base: codex/main-mobench-v0137
Head: codex/main-mobench-fixtures @ 7ef0833c22e782d6467193fe116d637f2b2ef415

Configuration: mobench 0.1.37, profile smoke, release build, iterations=2, warmup=1.

Requested fixtures/functions:

bench_mobile::bench_passport_complete_age_check_prove
bench_mobile::bench_oprf_prove
bench_mobile::bench_p256_bigcurve_prove

No benchmark timings were produced by this CI run. Both platform jobs failed before writing mobench summary JSON, so the workflow summary job skipped the automatic sticky comment.

Platform	Device	Result
iOS	`iPhone 7-10`	Failed before benchmark execution. BrowserStack rejected the uploaded IPA/XCUITest run with HTTP 422 because the iPhone 7 iOS version is lower than the minimum required by the uploaded app/test bundle.
Android	`Vivo Y21-11.0`	Timed out after `3600s` waiting for BrowserStack build `2025943d5761a815a268c400fecac703fedbec6a` to complete. Dashboard.

Measured: none.
Not measured: all three requested fixtures on iPhone 7 and Vivo Y21.

dcbuild3r · 2026-04-30T09:31:07Z

Superseded by #3 to use the required dcbuild3r/ branch naming convention.

dcbuilder.eth added 4 commits April 29, 2026 16:03

ci: add oprf and p256 mobench fixtures

7cee8b0

ci: harden mobench sticky comment reporting

b90b308

ci: run mobench smoke on low-end devices

c94bc39

fix: refresh mobench fixtures for main

c5caecc

dcbuild3r temporarily deployed to Browserstack April 29, 2026 14:10 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 29, 2026 14:10 — with GitHub Actions Error

dcbuild3r had a problem deploying to Browserstack April 29, 2026 14:10 — with GitHub Actions Failure

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

fix: use compatible low-end mobench devices

65489af

dcbuild3r temporarily deployed to Browserstack April 29, 2026 15:06 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 29, 2026 15:07 — with GitHub Actions Failure

dcbuild3r temporarily deployed to Browserstack April 29, 2026 15:08 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 29, 2026 15:08 — with GitHub Actions Error

dcbuild3r had a problem deploying to Browserstack April 29, 2026 15:08 — with GitHub Actions Failure

fix: lower ios mobench deployment target

7ef0833

dcbuild3r temporarily deployed to Browserstack April 29, 2026 15:50 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 29, 2026 15:51 — with GitHub Actions Failure

fix: support low-end mobench CI runs

caa5338

dcbuild3r temporarily deployed to Browserstack April 30, 2026 07:14 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 07:14 — with GitHub Actions Failure

dcbuild3r temporarily deployed to Browserstack April 30, 2026 07:16 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 07:16 — with GitHub Actions Failure

dcbuild3r had a problem deploying to Browserstack April 30, 2026 07:16 — with GitHub Actions Error

fix: use UIKit mobench runner for iOS 10

fee5c49

dcbuild3r temporarily deployed to Browserstack April 30, 2026 07:48 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 07:48 — with GitHub Actions Failure

fix: avoid ios 11 json option in mobench runner

6f132d0

dcbuild3r temporarily deployed to Browserstack April 30, 2026 08:20 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 08:20 — with GitHub Actions Failure

fix: run iphone 7 mobench on supported ios

5dd8311

dcbuild3r had a problem deploying to Browserstack April 30, 2026 08:58 — with GitHub Actions Error

dcbuild3r temporarily deployed to Browserstack April 30, 2026 08:58 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 08:58 — with GitHub Actions Failure

fix: keep iphone 7 browserstack inventory target

9839862

dcbuild3r mentioned this pull request Apr 30, 2026

Run main-based mobench fixtures on low-end devices #3

Closed

dcbuild3r closed this Apr 30, 2026

dcbuild3r deleted the codex/main-mobench-fixtures branch April 30, 2026 09:31

dcbuild3r temporarily deployed to Browserstack April 30, 2026 09:31 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 09:31 — with GitHub Actions Error

dcbuild3r temporarily deployed to Browserstack April 30, 2026 09:33 — with GitHub Actions Inactive

dcbuild3r had a problem deploying to Browserstack April 30, 2026 09:33 — with GitHub Actions Error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run main-based mobench fixtures on low-end devices#2

Run main-based mobench fixtures on low-end devices#2
dcbuild3r wants to merge 11 commits into
codex/main-mobench-v0137from
codex/main-mobench-fixtures

dcbuild3r commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 29, 2026

Uh oh!

dcbuild3r commented Apr 29, 2026

Uh oh!

dcbuild3r commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dcbuild3r commented Apr 29, 2026

Summary

Validation

Not measured yet

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

dcbuild3r commented Apr 29, 2026

Mobench BrowserStack smoke

Uh oh!

dcbuild3r commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant