Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
(I didn't create an issue for this)
I was working on a shell script for for another addon request, and noticed that my editor's defaults didn't match ddev conventions. I went looking for a .editorconfig and didn't find one in the repo I was working on, so I tried adding one.
In a review, @stasadev asked me to update the template (i.e.: this repo) with an editorconfig; and update the UpdateChecker, and update the .gitattributes.
How This PR Solves The Issue
Adds an editorconfig. Adds a simple test for it in UpdateChecker. Adds the .editorconfig to the export-ignore list.
Manual Testing Instructions
.shfile in the project using an editor that supports the EditorConfig standard with default configurationtabkey:Automated Testing Overview
I updated the UpdateChecker test to look for the
charset = utf-8line, since that's probably a thing that should be in all ddev add-ons.Release/Deployment Notes
None.