Improve integrations with metadata and debug routes#338
Merged
Conversation
nemunaire
changed the title
nemunaire
force-pushed
the
integration-improvements
branch
from
1c030fc to
a5bd8c2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| localPath := path.Join(d.rootPath, path.Clean(decoded)) | ||
| return os.Open(localPath) | ||
|
|
||
| st, err := os.Stat(localPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| return nil, 0, err | ||
| } | ||
|
|
||
| res, err := os.Open(localPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #240, this implements metadata retrieval, improve download (size is now given) and add some API routes to be able to explore each integrations from the UI (currently not implemented in the UI, but it's already great to debug integrations in the browser instead of the tablet).
Metadata on the tablet permit to display non-convertible files as such, ...
Implemented and tested against all existing integrations except Dropbox.