Skip to content

[FIX] 임시 인프라 러너 태그에 맞게 CD 스크립트 수정#248

Merged
unifolio0 merged 1 commit into
developfrom
fix/#247-runner-tag-change
May 11, 2026
Merged

[FIX] 임시 인프라 러너 태그에 맞게 CD 스크립트 수정#248
unifolio0 merged 1 commit into
developfrom
fix/#247-runner-tag-change

Conversation

@coli-geonwoo
Copy link
Copy Markdown
Contributor

@coli-geonwoo coli-geonwoo commented May 11, 2026

🚩 연관 이슈

closed #247

🗣️ 리뷰 요구사항 (선택)

Summary by CodeRabbit

  • Chores
    • 배포 인프라 환경이 업데이트되었습니다.

Review Change Stack

@coli-geonwoo coli-geonwoo linked an issue May 11, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

개요

개발 및 프로덕션 CD 워크플로우에서 배포 작업의 실행 환경 레이블을 각각 dev-temp, prod-temp의 임시 인프라로 변경합니다.

변경 사항

러너 구성 변경

레이어 / 파일 요약
배포 러너 환경 업데이트
.github/workflows/Dev_CD.yml, .github/workflows/Prod_CD.yml
개발 환경의 runs-on 값을 dev에서 dev-temp로 변경하고, 프로덕션 환경의 runs-on 값을 prod에서 prod-temp로 변경합니다.

🎯 1 (Trivial) | ⏱️ ~2분

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 CD 스크립트의 주요 변경사항인 임시 인프라 러너 태그 수정을 명확하고 간결하게 설명합니다.
Description check ✅ Passed PR 설명은 템플릿 구조를 따르며 연관 이슈(#247)를 명시했으나, 리뷰 요구사항 섹션이 비어있습니다.
Linked Issues check ✅ Passed PR의 코드 변경(Dev_CD.yml, Prod_CD.yml의 러너 태그 변경)이 이슈 #247의 목표(임시 인프라 러너 태그 수정)를 완전히 충족합니다.
Out of Scope Changes check ✅ Passed 모든 코드 변경이 이슈 #247의 범위 내에 있으며, 임시 인프라 러너 태그 수정만 포함되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#247-runner-tag-change

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@unifolio0 unifolio0 self-requested a review May 11, 2026 12:35
@unifolio0 unifolio0 added the fix 기능 수정 label May 11, 2026
@unifolio0 unifolio0 requested a review from leegwichan May 11, 2026 12:35
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.github/workflows/Dev_CD.yml (1)

55-55: ⚡ Quick win

actionlint 경고를 억제하기 위한 설정 파일 추가 권장

셀프 호스팅 러너를 사용하는 경우, actionlint의 false positive를 방지하기 위해 .github/actionlint.yaml 파일을 추가하는 것을 권장합니다.

📝 actionlint.yaml 설정 예시

.github/actionlint.yaml 파일을 생성하세요:

self-hosted-runner:
  labels:
    - dev-temp
    - prod-temp

이렇게 하면 정적 분석 도구가 커스텀 러너 레이블을 인식하여 불필요한 경고를 발생시키지 않습니다.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/Dev_CD.yml at line 55, Add a new actionlint config file to
suppress false positives for your self-hosted runner label used in the workflow:
create .github/actionlint.yaml that defines the self-hosted-runner.labels
mapping and include the labels referenced by the workflow (e.g., dev-temp and
prod-temp) so actionlint recognizes the custom runs-on: dev-temp label used in
the Dev_CD.yml workflow.
.github/workflows/Prod_CD.yml (1)

55-55: 임시 인프라 사용에 대한 문서화 및 롤백 계획 권장

러너 이름에 "temp" 접미사가 붙어 있어 임시 인프라로 보입니다. 다음 사항들을 고려해주세요:

  1. 문서화: 임시 인프라 사용 이유, 예상 사용 기간, 영구 인프라로의 전환 계획을 문서화 (예: README, wiki, 또는 이슈 코멘트)
  2. 롤백 계획: 임시 러너에 문제가 발생할 경우 이전 러너(prod)로 빠르게 되돌릴 수 있는 절차 수립
  3. 모니터링: 임시 인프라의 안정성과 성능을 모니터링하여 프로덕션 배포에 영향이 없는지 확인
  4. 알림: 팀원들에게 임시 인프라 사용 사실을 공지하여 예상치 못한 배포 실패 시 빠르게 대응할 수 있도록 함
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/Prod_CD.yml at line 55, The workflow currently targets a
temporary runner ("runs-on: prod-temp"); update project docs and the deployment
workflow to reflect this by adding documentation (README or wiki) describing why
"prod-temp" is used, expected duration, and plan to migrate to the permanent
runner, and implement a rollback/override mechanism in the pipeline to switch
back to the stable runner name ("prod") quickly (e.g., environment variable or
workflow input to set runs-on), plus add monitoring and alerting steps or links
to monitoring runbooks so the team is notified and can act if "prod-temp" shows
issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/Dev_CD.yml:
- Line 55: Add a new actionlint config file to suppress false positives for your
self-hosted runner label used in the workflow: create .github/actionlint.yaml
that defines the self-hosted-runner.labels mapping and include the labels
referenced by the workflow (e.g., dev-temp and prod-temp) so actionlint
recognizes the custom runs-on: dev-temp label used in the Dev_CD.yml workflow.

In @.github/workflows/Prod_CD.yml:
- Line 55: The workflow currently targets a temporary runner ("runs-on:
prod-temp"); update project docs and the deployment workflow to reflect this by
adding documentation (README or wiki) describing why "prod-temp" is used,
expected duration, and plan to migrate to the permanent runner, and implement a
rollback/override mechanism in the pipeline to switch back to the stable runner
name ("prod") quickly (e.g., environment variable or workflow input to set
runs-on), plus add monitoring and alerting steps or links to monitoring runbooks
so the team is notified and can act if "prod-temp" shows issues.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 20462e79-8d75-4532-81ea-8a929ae4d7c0

📥 Commits

Reviewing files that changed from the base of the PR and between d89c56f and d8e976c.

📒 Files selected for processing (2)
  • .github/workflows/Dev_CD.yml
  • .github/workflows/Prod_CD.yml

@github-actions
Copy link
Copy Markdown

Test Results

141 files  141 suites   19s ⏱️
301 tests 301 ✅ 0 💤 0 ❌
313 runs  313 ✅ 0 💤 0 ❌

Results for commit d8e976c.

@github-actions
Copy link
Copy Markdown

📝 Test Coverage Report

Overall Project 89.27% 🍏

There is no coverage information present for the Files changed

Copy link
Copy Markdown
Contributor

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

@unifolio0 unifolio0 merged commit 079dfc8 into develop May 11, 2026
8 checks passed
@unifolio0 unifolio0 deleted the fix/#247-runner-tag-change branch May 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 기능 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 이전 임시 인프라에 맞게 runner 태그 수정

3 participants