Skip to content

Add UNIT #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gebsl wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add UNIT #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55abad
Added UNIT to toXML, fromXML and Interface.
Aug 12, 2024
76c45d1
Merge pull request #1 from richard-hoffman-viiz/main
andrewhamill Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ export interface CivicAddress {
* Example: Joe's Barbershop
*/
NAM?: string,
/**
* Unit (apartment, suite) \
* https://datatracker.ietf.org/doc/html/rfc5139#page-4 \
* Example: 12a
*/
UNIT?: string,
/**
* Postal code \
* Example: 10027-0401
Expand Down
2 changes: 2 additions & 0 deletions src/pidf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export class Civic extends Location {
FLR: Civic.getValueIfAvailable(node, 'FLR'),
NAM: Civic.getValueIfAvailable(node, 'NAM'),
PC: Civic.getValueIfAvailable(node, 'PC'),
UNIT: Civic.getValueIfAvailable(node, 'UNIT'),
};

return new Civic(addr, method);
Expand Down Expand Up @@ -97,6 +98,7 @@ export class Civic extends Location {
Civic.addElementIfNotUndefined(doc, root, prefix, 'FLR', adr.FLR);
Civic.addElementIfNotUndefined(doc, root, prefix, 'NAM', adr.NAM);
Civic.addElementIfNotUndefined(doc, root, prefix, 'PC', adr.PC);
Civic.addElementIfNotUndefined(doc, root, prefix, 'UNIT', adr.UNIT);

return root;
}
Expand Down