fix: resolve bare model names to connection defaultModel before upstream calls#474
Open
anuragg-saxenaa wants to merge 4 commits intodecolua:masterfrom
Open
fix: resolve bare model names to connection defaultModel before upstream calls#474anuragg-saxenaa wants to merge 4 commits intodecolua:masterfrom
anuragg-saxenaa wants to merge 4 commits intodecolua:masterfrom
Conversation
…eam calls When a connection uses a bare model name (e.g. "auto", "pro") in its alias, the qualified model string like "minimax/auto" was sent upstream — but "auto" is not a valid MiniMax model ID. This caused API rejections. Now getProviderCredentials returns defaultModel from the selected connection, and both handleChatCore/handleEmbeddingsCore receive the resolved real model ID instead of the alias. Only applies to bare names (no "/" separator). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getProviderCredentialsnow returnsdefaultModelfrom the selected connectionhandleChatCoreandhandleEmbeddingsCoreuse the resolved real model ID instead of bare alias names (e.g. "auto") when no "/" separator is presentTest plan
🤖 Generated with Claude Code