Security: Dangerous unauthenticated global package installation endpoint#520
Open
tuanaiseo wants to merge 1 commit intodecolua:masterfrom
Open
Conversation
The install route executes `npm install -g 9remote` via `child_process.exec` on POST with no visible auth checks. This allows remote triggering of privileged package installation, creating severe supply-chain and host-compromise risk. Affected files: route.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The install route executes
npm install -g 9remoteviachild_process.execon POST with no visible auth checks. This allows remote triggering of privileged package installation, creating severe supply-chain and host-compromise risk.Severity:
criticalFile:
src/app/api/9remote/install/route.jsSolution
Remove this endpoint from production. If absolutely required, enforce admin authentication, CSRF protection, strict allowlisting, rate limiting, audit logging, and run in a sandboxed non-privileged worker instead of the web process.
Changes
src/app/api/9remote/install/route.js(modified)Testing