Skip to content

feat(groups): improve dashboard group action feedback#320

Open
catwithtudou wants to merge 1 commit into
deepcoldy:masterfrom
catwithtudou:scott9/improve-groups-dashboard-feedback
Open

feat(groups): improve dashboard group action feedback#320
catwithtudou wants to merge 1 commit into
deepcoldy:masterfrom
catwithtudou:scott9/improve-groups-dashboard-feedback

Conversation

@catwithtudou

Copy link
Copy Markdown
Contributor

Summary

  • Keep the group creation dialog open on validation, network, and API failures, and render the reason inline so users can fix the form and retry.
  • Replace the add-bots alert/auto-close flow with inline per-bot results, including partial failures and the no-proxy-bot case.
  • Add a small helper test for the add-bots result summary, including escaping ids and backend error text.

Validation

  • CI=true npx --yes pnpm@9.5.0 vitest run --project unit test/dashboard-groups-helpers.test.ts
  • CI=true npx --yes pnpm@9.5.0 vitest run --project unit test/dashboard-groups-helpers.test.ts test/dashboard-groups-command.test.ts test/groups-card-model.test.ts test/groups-card-dispatch.test.ts
  • CI=true npx --yes pnpm@9.5.0 build
  • Static Playwright/Chrome smoke for narrow dialog inline-status rendering: no horizontal overflow.

Notes

This PR only changes Dashboard group UI feedback. It does not change group creation, add-bots, or oncall backend behavior.

@catwithtudou catwithtudou requested a review from deepcoldy as a code owner June 27, 2026 08:17
@catwithtudou catwithtudou force-pushed the scott9/improve-groups-dashboard-feedback branch from 6d1eac5 to eb142e9 Compare June 27, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant