fix!: hardcode machine image to batch-cos instead of batch-debian#10
Closed
SophiaPerzan-DG wants to merge 8 commits intodg-cifrom
Closed
fix!: hardcode machine image to batch-cos instead of batch-debian#10SophiaPerzan-DG wants to merge 8 commits intodg-cifrom
SophiaPerzan-DG wants to merge 8 commits intodg-cifrom
Conversation
…e backend (#1) * WX-1810 WX-1830 n1/n2/n2d machine types, cpuPlatform on GCPBATCH (broadinstitute#7518) * feat: [GCP Batch] Support passing standard machine types to the Google backend --------- Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com> @ Conflicts: @ CHANGELOG.md @ supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/api/GcpBatchRequestFactoryImpl.scala @ supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/models/GcpBatchRuntimeAttributes.scala @ supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/util/GcpBatchMachineConstraints.scala @ supportedBackends/google/batch/src/test/scala/cromwell/backend/google/batch/models/GcpBatchRuntimeAttributesSpec.scala @ supportedBackends/google/batch/src/test/scala/cromwell/backend/google/batch/util/GcpBatchMachineConstraintsSpec.scala
must be done ahead of skipping tests
also: make github actions pass - BROADBOT_GITHUB_TOKEN => GITHUB_TOKEN - broadbot => dg bot - remove workflow that updates helm chart we don't use - update upstream where applicable - fix formatting with sbt scalafmtAll - skip unit tests that require azure auth
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
deleted test "return Github import auth provider when Azure auth is enabled"
|
Try rebasing on latest upstream to fix the github actions? |
ovesh
reviewed
Dec 3, 2025
| } else { | ||
| Disk.newBuilder | ||
| } | ||
| disk.setImage("batch-debian") |
There was a problem hiding this comment.
This was done to support #8 (see PR description). Need to be careful with unintended side effects of reverting that change.
Looking at the code above, you can get a similar effect by explicitly specifying batch-cos as the boot disk in the task's runtime attributes.
SophiaPerzan-DG
force-pushed
the
dg-ci
branch
from
f49c3f1 to
fabdded
Compare
Collaborator
Author
|
Superseded by #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.