Fix how public headers are collected from PodSpec #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files is defined. Add tests. Add test cleanup
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 26%
com/defold/extender/builders - 0%
com/defold/extender/cache - 35.4%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 0%
com/defold/extender/metrics - 7.4%
com/defold/extender/process - 10.4%
com/defold/extender/remote - 4.9%
com/defold/extender/services - 33.7%
com/defold/extender/services/cocoapods - 51.4%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 18.7%
com/defold/extender/utils - 0%
|
ekharkunov
commented
Jan 29, 2026
| this.publicHeaders.addAll(PodUtils.listFilesGlob(this.dir, pattern)); | ||
| } | ||
| } else { | ||
| for (String pattern : spec.sourceFilesPatterns) { |
Contributor
Author
There was a problem hiding this comment.
If not public_header_files defined - collect headers from sources.
| // find source and header files | ||
| // https://guides.cocoapods.org/syntax/podspec.html#source_files | ||
| spec.sourceFilesPatterns.addAll(getAsList(specJson, "source_files")); | ||
| if (platformSettings != null) spec.sourceFilesPatterns.addAll(getAsList(platformSettings, "source_files")); |
Contributor
Author
There was a problem hiding this comment.
Collect source files from platform settings (see AppAuth.json as example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public_header_filesdefined all headers from sources enumerated as public. It fixes what VFS overlay file contains in case ofGoogleSignInpodFixes #835