Skip to content

docs: audit menus and item builder pages#17

Merged
demengc merged 1 commit intomainfrom
worktree-agent-ae754516
Mar 24, 2026
Merged

docs: audit menus and item builder pages#17
demengc merged 1 commit intomainfrom
worktree-agent-ae754516

Conversation

@demengc
Copy link
Copy Markdown
Owner

@demengc demengc commented Mar 24, 2026

Summary

  • Fix createCommandHandler() usage in menus.md to include the required .build() call (it returns Lamp.Builder, not Lamp)
  • Restructure both pages with dense reference tables for all API methods, replacing scattered code-only snippets
  • Correct the glow effect example in item-builder.md to remove redundant flags(ItemFlag.HIDE_ENCHANTS) (already applied internally by glow(true))
  • Document all 5 MenuButton.create() overloads with slot-handling semantics
  • Add inventory slot grid diagram and indexing table clarifying 0-based (code) vs 1-based (config) for slots, rows, and columns
  • Document copy() shallow reference semantics, addStaticButton(), applyFillersFromConfig(), onClose callback, and static material utilities

Test plan

  • Verify markdown renders correctly on GitBook
  • Confirm all code examples compile against the current API
  • Check that table formatting displays properly in GitBook

Fix createCommandHandler() usage to include .build() call. Restructure
both pages with reference tables for all API methods, accurate slot
indexing documentation, and corrected code examples. Remove redundant
glow+HIDE_ENCHANTS pattern. Document all MenuButton.create() overloads,
fill methods, copy() shallow semantics, and static material utilities.
@demengc demengc merged commit 94e6212 into main Mar 24, 2026
2 of 3 checks passed
@demengc demengc deleted the worktree-agent-ae754516 branch March 24, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant