Conversation
Fix batch.bind() -> batch.batch() bug, simplify constructor examples to use null defaults instead of manual JDBC URL building, document async method variants with table, add constants reference, document low-level access methods, correct interface hierarchy in cleanup section, use built-in executeAsync/queryAsync instead of Schedulers.async() wrapper in examples, and restructure page for information density.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch.bind()->batch.batch()bug (method name did not matchBatchBuilderAPI)nulldefaults instead of manually building the JDBC URL stringSql.MYSQL_DRIVER,Sql.MYSQL_LEGACY_DRIVER, andSql.DEFAULT_JDBC_URLconstants in a reference tableSchedulers.async()wrapping in examples with the built-inexecuteAsync/queryAsyncmethodsSqlCredentials.of(ConfigurationSection)factory methodstream(),getConnection(),getHikari())BatchBuilder.execute()andBatchBuilder.reset()methodsSqlimplementsISqlwhich extendsTerminable(not directlyAutoCloseable)execute(String)andquery(String, SqlFunction)where appropriateTest plan