ci: bump ci and local node to 22 lts#288
Merged
Merged
Conversation
Pin the test job matrix and the spell-check workflow to Node 22, and align .nvmrc to match. This satisfies puppeteer v25's engine requirement (node >=22.12) and unblocks #286 / PR #285. The Lighthouse step is left on Node 20.x: @lhci/cli@0.12.x predates Node 22 and the step is already non-blocking. Bumping LHCI is tracked separately. Closes #287 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testjob matrix intest.ymlfrom Node 20.x → 22.x to satisfy puppeteer v25's engine requirement (node >=22.12), unblocking fix(tests): puppeteer v25 breaks Jest functional tests (ESM entry + Node 20 engine) #286 / PR fix(deps): bump puppeteer from 24.43.0 to 25.0.4 #285.misspell.yml) from Node 18 → 22 (cspell@10 already requires ≥20, so this also clears existing drift)..nvmrcfrom 18 → 22 to align local dev with CI.@lhci/cli@0.12.xpredates Node 22 and the step is already non-blocking (lhci autorun ... || true). Bumping LHCI is intentionally out of scope and tracked separately.Netlify deploys and the local Docker dev image use no Node, so they are unaffected.
Test plan
Website Testsjob runs on Node 22 and is green (jest functional, accessibility, link check, hugo build)Spell Checkworkflow runs on Node 22 and passesEBADENGINEwarnings in the CI npm install stepCloses #287
🤖 Generated with Claude Code