fix(install): cap redirects in fetchRawText to prevent loops#73
Merged
Conversation
fetchRawText followed 301/302 redirects by recursing with no depth limit, so a redirect cycle caused unbounded recursion and request fan-out before any failure surfaced. Cap the chain at 5 hops and resolve null (the existing fetch-failure contract) when the budget is exhausted or a Location header is absent. Closes #69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchRawTextfollowed 301/302 redirects via unbounded recursion — a redirect cycle caused infinite recursion and request fan-out. Now caps the chain at 5 hops and resolvesnull(the existing fetch-failure contract) when the budget runs out orLocationis missing.Tests
Added 3
node --testcases intests/install.test.js:null(no overflow)LocationresolvesnullFull suite: 11/11 green.
Closes #69
🤖 Generated with Claude Code