ci(npm-publish): harden GitHub Packages publish job#80
Merged
Conversation
Add a pre-publish verification step to publish-gpr that asserts the scoped name mutation took effect (@derek-palmer/codeforerunner) and the tag matches package.json version, so a failed rename or mismatch can't ship a mislabeled scoped package. Add workflow tests covering the job's packages:write/token auth (not OIDC), scoped mutation, the verification guard, and that the scoped rename does not leak into the public npmjs publish job. Closes #47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47.
What
Hardens the GitHub Packages (
publish-gpr) job, keeping it isolated from npmjs trusted publishing:npm pkg set name="@derek-palmer/codeforerunner", asserts the scoped name actually took effect and the tag matchespackage.jsonversion beforenpm publish. A failed/partial rename or version mismatch now fails loudly instead of shipping a mislabeled scoped package.publish-gprusespackages: writetoken auth (not OIDCid-token), runsneeds: publish, performs the scoped mutation withNODE_AUTH_TOKEN, includes the verification guard, and that the scoped rename does not leak into the public npmjspublishjob.Package identity, registry auth (
GITHUB_TOKEN), and the separate-job structure are unchanged.Out of scope
npmjs trusted publishing changes (#48), shim pins, removing the GitHub Packages surface.
🤖 Generated with Claude Code