Skip to content

Allow dots in SSH usernames #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbrodie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow dots in SSH usernames #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/security/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ func (iv *InputValidator) ValidateSSHUser(username string) error {
return fmt.Errorf("SSH username too long: %d characters (max %d)", len(username), MaxSSHUserLength)
}

// SSH usernames should only contain alphanumeric characters, hyphens, and underscores
validUserRegex := regexp.MustCompile(`^[a-zA-Z0-9_\-]+$`)
// SSH usernames should only contain alphanumeric characters, hyphens, underscores, and dots
validUserRegex := regexp.MustCompile(`^[a-zA-Z0-9_\-\.]+$`)
if !validUserRegex.MatchString(username) {
return fmt.Errorf("SSH username contains invalid characters (only alphanumeric, hyphen, underscore allowed)")
return fmt.Errorf("SSH username contains invalid characters (only alphanumeric, hyphen, underscore, dot allowed)")
}

// Cannot start with hyphen or number
Expand Down
3 changes: 2 additions & 1 deletion internal/security/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ func TestValidateSSHUser(t *testing.T) {
{"valid_with_hyphen", "user-name", false, ""},
{"valid_with_numbers", "user123", false, ""},
{"valid_mixed", "my_user-123", false, ""},
{"valid_with_dot", "user.name", false, ""},
{"valid_with_multiple_dots", "first.last.name", false, ""},

// Invalid usernames
{"empty_username", "", true, "cannot be empty"},
Expand All @@ -199,7 +201,6 @@ func TestValidateSSHUser(t *testing.T) {
{"starts_with_number", "1user", true, "cannot start with hyphen or number"},
{"invalid_chars_space", "user name", true, "invalid characters"},
{"invalid_chars_special", "user@host", true, "invalid characters"},
{"invalid_chars_dot", "user.name", true, "invalid characters"},
{"invalid_chars_slash", "user/name", true, "invalid characters"},
}

Expand Down