Add createLazyCallable implementation and docs#63
Closed
flt3150sk wants to merge 1 commit intodesko27:mainfrom
Closed
Add createLazyCallable implementation and docs#63flt3150sk wants to merge 1 commit intodesko27:mainfrom
flt3150sk wants to merge 1 commit intodesko27:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
I created this PR in response to the related issue, but after reconsidering the actual use case, I'm starting to think that this change may not be strictly necessary. If you feel that the priority is low, please feel free to close it. I'd be happy if you could take a quick look whenever you have time. |
Owner
|
Hey @flt3150sk! Sorry for the late reply. I forgot to mention in #55 that I’d rather not increase the bundle size unless really needed 🙏🏻 That said, adding a note to the README to explain how to do lazy loading using the official React API sounds great. Happy to merge a PR for that — thanks a lot for your contributions, really appreciated! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Feature: Implement createLazyCallable
Description
Implemented the
createLazyCallablefeature proposed in GitHub issue #55.This feature allows for more concise syntax when using React lazy loading with react-call.
Motivation
Current approach:
New approach:
This change simplifies lazy loading syntax and improves developer experience.
Changes
src/createLazyCallable/index.tsx- New createLazyCallable function implementationsrc/main.ts- Added createLazyCallable exporttests/src/lazy.test.tsx- Comprehensive test suite addeddemo/src/CallableScenes/YourLazy.tsx- Demo component addedREADME.md- Added Lazy loading sectionUsage Example
Screenshots / Demos
Demo Site Functionality
createLazyCallable-site.mov
Bundle Analyzer Verification
createLazyCallable-analyze.mov
index-xxx.jsYourLazy-xxx.js← Evidence of code splittingRelated Issues
Fixes #55
Checklist
Notes for Reviewers
demo/src/CallableScenes/YourLazy.tsxand demo site additions are for functionality verification and bundle analysis