chore: fix shortcut for zoom in on page

[quuu]

Zoom in (Cmd + =) didn't work before, because the shortcut was assigned to CmdOrCtrl + +, which doesn't actually work because it's a 3 key modifier (+ = Shift + =)

Tested and confirmed I can zoom in on pages now with this change

[quuu]

@aavshr

[aavshr]

thanks a lot for the PR @quuu

Cmd + = is however only convenient for keyboard layouts where + and = are on the same physical location. Many layouts don't have this.

The expected shortcut should still be with + as that means zoom and is the standard behavior of other browsers as well.

It would be great if you could add support for registering multiple combos where we would also add Cmd + = as an alternate additionally with Cmd + +.

Will need to make changes to the keyboard manager for shortcuts.

[quuu]

@aavshr i get what you mean - wondering what you'd recommend as a longer term solution?

Can confirm that on chrome, it shows "Cmd +"

But on Deta, Cmd + doesn't do anything for me (assuming it's because from my US layout, it's reading my key as Cmd =)

[aavshr]

wondering what you'd recommend as a longer term solution?

We should add support for both shortcuts! For that we need to support alternate shortcuts for the same action which we do not have right now.

But on Deta, Cmd + doesn't do anything for me

yes not sure why that's the case but it's a bug.