-
Notifications
You must be signed in to change notification settings - Fork 218
Add a feature to be able to select a custom background image for surf #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
i mean they can bring the surflets and the desktop surf back (like that thing with the wallpaper on it) and improve the vertical tab a bit |
|
i think i should add some features like preload link pages this will be a great revolution as no browser does this and this can make things fast AF |
|
May I ask if directly uploading custom local images is allowed? |
|
yo, i dont think custom images are allowed due to the cors restrictions however it might work with some changes that move the image to appdata (windows) or the config folders where surf's data is stored btw, can i get the link to that background its lovely |
|
GeoffBao@7da66f8#diff-214729737fb237e4f6cfa94ec26a2733e1fe390ce759404247178a5a8015825e I made some modifications for reference, thank you. |
|
hell yeah |
@ForLoopCodes no? i mean u can still upload it locally, NOT pull it online |
|
wym |
@ForLoopCodes i mean like i can drag and drop to the desktop (old method) and right click it and set it as a wallpaper for my rice :3 |
|
good idea :o |
aavshr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for the PR @ForLoopCodes , the vibes are great with the custom background!
Loading arbitrary image urls like this is susceptible to css injection attacks (even though the user puts the url, they might not always be aware) without sanitization, and also could be a privacy concern.
I think the best implementation of a v0 of this feature would be to allow setting/removing an image you already have in Surf as the background through the right-click context menu! And from the Settings, you can just remove an already set background.
After this, we could additionally allow you to choose a local image from the Settings itself.
You also committed the bun.lock file which we should not be there. Also the yarn.lock file has a lot of changes, not sure why.
There seem to be other changes unrelated to the feature, (tsconfig, package.json etc) which might make sense but can you please open them in a different PR?
|
surely, would love to do that once my exams are finished |

sometimes, i write bad code
please let me know if the code is not production ready or needs any changes