Skip to content

Conversation

@ForLoopCodes
Copy link

  • Added input field and buttons in Settings.svelte
  • Wired up the logic to save the URL to user settings and trigger updates
  • Fixed some timing issues for smooth, immediate feedback
image image

sometimes, i write bad code
please let me know if the code is not production ready or needs any changes

@Omarplayz233
Copy link

i mean they can bring the surflets and the desktop surf back (like that thing with the wallpaper on it) and improve the vertical tab a bit
and revamp the new tab page to be custom (either the old style or the new style aka the surflets and desktop or the search and docs)
and also jst so it can be customizable and not THAT boring

@ForLoopCodes
Copy link
Author

i think i should add some features like preload link pages

this will be a great revolution as no browser does this and this can make things fast AF

@GeoffBao
Copy link

GeoffBao commented Nov 6, 2025

May I ask if directly uploading custom local images is allowed?

@GeoffBao
Copy link

GeoffBao commented Nov 6, 2025

CleanShot 2025-11-06 at 13 33 26@2x

so beautiful ...

@ForLoopCodes
Copy link
Author

yo, i dont think custom images are allowed due to the cors restrictions

however it might work with some changes that move the image to appdata (windows) or the config folders where surf's data is stored

btw, can i get the link to that background its lovely

@GeoffBao
Copy link

GeoffBao commented Nov 6, 2025

GeoffBao@7da66f8#diff-214729737fb237e4f6cfa94ec26a2733e1fe390ce759404247178a5a8015825e

I made some modifications for reference, thank you.

@GeoffBao
Copy link

GeoffBao commented Nov 6, 2025

yo, i dont think custom images are allowed due to the cors restrictions

however it might work with some changes that move the image to appdata (windows) or the config folders where surf's data is stored

btw, can i get the link to that background its lovely

https://blog-frontend.envato.com/cdn-cgi/image/width=2400,quality=75,format=auto/uploads/sites/2/2025/02/Ghibli-aesthetic.webp

@ForLoopCodes
Copy link
Author

GeoffBao@7da66f8#diff-214729737fb237e4f6cfa94ec26a2733e1fe390ce759404247178a5a8015825e

I made some modifications for reference, thank you.

hell yeah

@Omarplayz233
Copy link

yo, i dont think custom images are allowed due to the cors restrictions

however it might work with some changes that move the image to appdata (windows) or the config folders where surf's data is stored

btw, can i get the link to that background its lovely

@ForLoopCodes no? i mean u can still upload it locally, NOT pull it online

@ForLoopCodes
Copy link
Author

wym

@Omarplayz233
Copy link

wym

@ForLoopCodes i mean like i can drag and drop to the desktop (old method) and right click it and set it as a wallpaper for my rice :3

@ForLoopCodes
Copy link
Author

good idea :o

@aavshr aavshr self-requested a review November 7, 2025 11:06
Copy link
Collaborator

@aavshr aavshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the PR @ForLoopCodes , the vibes are great with the custom background!

Loading arbitrary image urls like this is susceptible to css injection attacks (even though the user puts the url, they might not always be aware) without sanitization, and also could be a privacy concern.

I think the best implementation of a v0 of this feature would be to allow setting/removing an image you already have in Surf as the background through the right-click context menu! And from the Settings, you can just remove an already set background.

After this, we could additionally allow you to choose a local image from the Settings itself.

You also committed the bun.lock file which we should not be there. Also the yarn.lock file has a lot of changes, not sure why.

There seem to be other changes unrelated to the feature, (tsconfig, package.json etc) which might make sense but can you please open them in a different PR?

@ForLoopCodes
Copy link
Author

surely, would love to do that once my exams are finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants