feat(schema): series→season→episode hierarchy fields (0.9.0)#11
Merged
Conversation
Extend the media browse contract so clients can render a TV/anime tree instead of a flat list: - media-item.schema.json: add `season` to the `type` enum and the optional hierarchy fields `parent_id`, `season_number`, `episode_number`, and `episode_title` (sourced from metadata_json). - library-query.schema.json: document the `parentId` and `topLevel` scope params (fetch a series' children / return only top-level items) plus the pre-existing `libraryId` scope. - SchemaPaths: add mediaItem() + libraryQuery() path resolvers. - Lock the new contract with SchemaPathsTest assertions. - Bump Version::VERSION to 0.9.0 + CHANGELOG. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 4 medium |
| CodeStyle | 5 minor |
| Complexity | 1 medium |
🟢 Metrics 15 complexity · 0 duplication
Metric Results Complexity 15 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
============================================
+ Coverage 53.22% 53.40% +0.17%
- Complexity 353 355 +2
============================================
Files 34 34
Lines 1084 1088 +4
============================================
+ Hits 577 581 +4
Misses 507 507
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the media browse contract so clients (server + hub SPA via
@phlix/ui) can render TV/anime content as a series → season/specials → episode tree instead of one flat list. This is the schema/contract step; the server API and@phlix/uichanges that consume it land in follow-up PRs.Changes
schemas/media-item.schema.jsontypeenum gainsseason(alongsideseries/episode).parent_id(uuid|null),season_number(int|null),episode_number(int|null),episode_title(string|null) — all derived frommetadata_json.schemas/library-query.schema.jsonparentId(fetch a series' direct children),topLevel(return only parent-less items — movies + series), and the pre-existinglibraryIdscope.src/Schema/SchemaPaths.php— addmediaItem()+libraryQuery()path resolvers.SchemaPathsTestlocks the new enum value, hierarchy fields, and scope params.Version::VERSION→0.9.0+ CHANGELOG.Verification
phpunit— OK (293 tests, 2569 assertions)phpstan analyze(level 9) — No errorsphpcs --standard=PSR12 src/— clean🤖 Generated with Claude Code