feat: add server-settings schema + webhook event catalog (0.7)#7
Merged
Conversation
Add two bundled schema artifacts to phlix-shared as the single source of truth for editable server settings and webhook event types: - schemas/server-settings.schema.json (JSON Schema draft 2020-12): the 15 editable server settings, mirroring phlix-server's AdminSettingsController::ALLOWED_KEYS (key, type, group, constraints). - schemas/webhook-events.json: the 7 supported webhook event types (playback.*, library.updated, download.complete, recording.*, alert) plus the reserved internal webhook.test. Distinct from the plugin PSR-14 events in EventNameMap. - src/Schema/SchemaPaths.php: pure zero-I/O path resolver so consumers locate the bundled files without hardcoding the vendor path. Bumps Version::VERSION to 0.7.0 + CHANGELOG. Tests cover SchemaPaths (100%) and validate both schema files (well-formedness, exact key/type/ event coverage). PHPStan L9 + Psalm errorLevel 1 + PHPCS PSR-12 green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 7 medium |
| CodeStyle | 18 minor |
| Complexity | 1 medium |
🟢 Metrics 64 complexity · 0 duplication
Metric Results Complexity 64 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two bundled schema artifacts to phlix-shared as the single source of
truth for editable server settings and webhook event types:
editable server settings, mirroring phlix-server's
AdminSettingsController::ALLOWED_KEYS (key, type, group, constraints).
(playback., library.updated, download.complete, recording., alert)
plus the reserved internal webhook.test. Distinct from the plugin
PSR-14 events in EventNameMap.
locate the bundled files without hardcoding the vendor path.
Bumps Version::VERSION to 0.7.0 + CHANGELOG. Tests cover SchemaPaths
(100%) and validate both schema files (well-formedness, exact key/type/
event coverage). PHPStan L9 + Psalm errorLevel 1 + PHPCS PSR-12 green.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com