Skip to content

feat(shared): H.6a - hub federation frame types#8

Merged
detain merged 1 commit into
masterfrom
feat/shared-H6a-relay-frame-types
May 30, 2026
Merged

feat(shared): H.6a - hub federation frame types#8
detain merged 1 commit into
masterfrom
feat/shared-H6a-relay-frame-types

Conversation

@detain

@detain detain commented May 30, 2026

Copy link
Copy Markdown
Owner

Adds 7 new hub-federation frame types (0x09–0x0F) to the RelayFrameType enum for hub-to-hub WebSocket relay communication.

New types:

  • HUB_HELLO (0x09): Leaf→Master JSON handshake
  • HUB_HELLO_ACK (0x0A): Master→Leaf JSON response
  • HUB_HEARTBEAT (0x0B): Keep-alive probe
  • LIBRARY_SHARE_UPDATE (0x0C): Master→Leaf share sync
  • LIBRARY_SHARE_REVOKED (0x0D): Master→Leaf revocation
  • ADMIN_DELEGATION (0x0E): Master→Leaf admin grant/revoke
  • HUB_DISCONNECTED (0x0F): Clean close notification

Also adds label() match coverage and isValid range update.

PHPUnit 283 green.

… enum

Adds 7 new hub-federation frame types (0x09–0x0F) to the RelayFrameType
enum for hub-to-hub WebSocket relay communication.

New types:
- HUB_HELLO (0x09): Leaf→Master JSON handshake
- HUB_HELLO_ACK (0x0A): Master→Leaf JSON response
- HUB_HEARTBEAT (0x0B): Keep-alive probe
- LIBRARY_SHARE_UPDATE (0x0C): Master→Leaf share sync
- LIBRARY_SHARE_REVOKED (0x0D): Master→Leaf revocation
- ADMIN_DELEGATION (0x0E): Master→Leaf admin grant/revoke
- HUB_DISCONNECTED (0x0F): Clean close notification

Also adds label() match coverage and isValid range update.

PHPUnit 283 green.

Co-Authored-By: Claude <claude@anthropic.com>
@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.22%. Comparing base (d2455a5) to head (c4b6bf1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     52.92%   53.22%   +0.30%     
  Complexity      353      353              
============================================
  Files            34       34              
  Lines          1077     1084       +7     
============================================
+ Hits            570      577       +7     
  Misses          507      507              
Flag Coverage Δ
phpunit 53.22% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 7 medium

Alerts:
⚠ 7 issues (≤ 0 issues of at least minor severity)

Results:
7 new issues

Category Results
BestPractice 7 medium

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@detain detain merged commit afc91d8 into master May 30, 2026
8 of 9 checks passed
detain added a commit that referenced this pull request Jun 4, 2026
feat(shared): H.6a - hub federation frame types
detain added a commit that referenced this pull request Jun 4, 2026
feat(shared): H.6a - hub federation frame types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant