Add Trakt client_id/secret/redirect_uri to server-settings schema#9
Merged
Conversation
So phlix-server's admin Settings UI can expose the operator's Trakt.tv application credentials (the in-app half of configuring Trakt; env vars remain supported on the server side). New keys are in a "scrobblers" group: - trakt.client_id (string) - trakt.client_secret (string) - trakt.redirect_uri (string) Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the 18 keys (was 15). Full suite + phpstan green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 53.22% 53.22%
Complexity 353 353
=========================================
Files 34 34
Lines 1084 1084
=========================================
Hits 577 577
Misses 507 507
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
detain
added a commit
that referenced
this pull request
Jun 4, 2026
…ema (#9) So phlix-server's admin Settings UI can expose the operator's Trakt.tv application credentials (the in-app half of configuring Trakt; env vars remain supported on the server side). New keys are in a "scrobblers" group: - trakt.client_id (string) - trakt.client_secret (string) - trakt.redirect_uri (string) Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the 18 keys (was 15). Full suite + phpstan green.
detain
added a commit
that referenced
this pull request
Jun 4, 2026
…ema (#9) So phlix-server's admin Settings UI can expose the operator's Trakt.tv application credentials (the in-app half of configuring Trakt; env vars remain supported on the server side). New keys are in a "scrobblers" group: - trakt.client_id (string) - trakt.client_secret (string) - trakt.redirect_uri (string) Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the 18 keys (was 15). Full suite + phpstan green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three Trakt.tv operator-credential keys to the shared server-settings schema so phlix-server's admin Settings UI can render fields for them (the in-app half of the agreed "Both" approach for configuring Trakt; env-var support already shipped on the server in phlix-server#196).
New keys (group
scrobblers, allstring):trakt.client_idtrakt.client_secrettrakt.redirect_uriAdditive and backward-compatible (runtime defaults still live in phlix-server
config/*.php, per the schema's own contract).ServerSettingsSchemaTestupdated to expect 18 keys (was 15). Full suite (289) + phpstan green.Consumed by phlix-server via
composer update detain/phlix-sharedin a follow-up PR that adds the Settings form fields and makesTraktOAuthControllerread these fromserver_settings(DB) with precedence over env/file.🤖 Generated with Claude Code