Skip to content

Add Trakt client_id/secret/redirect_uri to server-settings schema#9

Merged
detain merged 1 commit into
masterfrom
feat/settings-schema-trakt-keys
Jun 1, 2026
Merged

Add Trakt client_id/secret/redirect_uri to server-settings schema#9
detain merged 1 commit into
masterfrom
feat/settings-schema-trakt-keys

Conversation

@detain

@detain detain commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Adds the three Trakt.tv operator-credential keys to the shared server-settings schema so phlix-server's admin Settings UI can render fields for them (the in-app half of the agreed "Both" approach for configuring Trakt; env-var support already shipped on the server in phlix-server#196).

New keys (group scrobblers, all string):

  • trakt.client_id
  • trakt.client_secret
  • trakt.redirect_uri

Additive and backward-compatible (runtime defaults still live in phlix-server config/*.php, per the schema's own contract). ServerSettingsSchemaTest updated to expect 18 keys (was 15). Full suite (289) + phpstan green.

Consumed by phlix-server via composer update detain/phlix-shared in a follow-up PR that adds the Settings form fields and makes TraktOAuthController read these from server_settings (DB) with precedence over env/file.

🤖 Generated with Claude Code

So phlix-server's admin Settings UI can expose the operator's Trakt.tv
application credentials (the in-app half of configuring Trakt; env vars remain
supported on the server side). New keys are in a "scrobblers" group:

- trakt.client_id (string)
- trakt.client_secret (string)
- trakt.redirect_uri (string)

Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the
18 keys (was 15). Full suite + phpstan green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@detain detain merged commit 63d2694 into master Jun 1, 2026
6 of 7 checks passed
@detain detain deleted the feat/settings-schema-trakt-keys branch June 1, 2026 12:43
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.22%. Comparing base (afc91d8) to head (9a47599).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage     53.22%   53.22%           
  Complexity      353      353           
=========================================
  Files            34       34           
  Lines          1084     1084           
=========================================
  Hits            577      577           
  Misses          507      507           
Flag Coverage Δ
phpunit 53.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

detain added a commit that referenced this pull request Jun 4, 2026
…ema (#9)

So phlix-server's admin Settings UI can expose the operator's Trakt.tv
application credentials (the in-app half of configuring Trakt; env vars remain
supported on the server side). New keys are in a "scrobblers" group:

- trakt.client_id (string)
- trakt.client_secret (string)
- trakt.redirect_uri (string)

Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the
18 keys (was 15). Full suite + phpstan green.
detain added a commit that referenced this pull request Jun 4, 2026
…ema (#9)

So phlix-server's admin Settings UI can expose the operator's Trakt.tv
application credentials (the in-app half of configuring Trakt; env vars remain
supported on the server side). New keys are in a "scrobblers" group:

- trakt.client_id (string)
- trakt.client_secret (string)
- trakt.redirect_uri (string)

Additive/backward-compatible. Updates ServerSettingsSchemaTest to expect the
18 keys (was 15). Full suite + phpstan green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant