feat(C0.1): phlix-ui repo skeleton#2
Merged
Conversation
- Rename placeholder/index.ts to Placeholder.vue - Fix Vue SFC default export imports - Fix LibraryQueryParams interface - Add jsdom and @vue/test-utils devDependencies - Fix test setup Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
detain
added a commit
that referenced
this pull request
Jun 2, 2026
Port the deleted React IntegrationsPage into @phlix/ui as AdminIntegrationsPage, consolidating the React arrSync + authProviders (OIDC/LDAP) modules into one AdminIntegrationsApi (src/api/admin/integrations.ts). Arr-sync status + manual trigger (30s timeout toast) + auto-sync toggle; per-provider enable/disable; OIDC + LDAP config modals (LDAP host/port/ssl/base_dn/bind_dn/bind_pw with masking + omit-blank-to-keep + test-connection). Wired into the admin route/menu seam (admin-integrations); exported. Reviewer finding #2 fixed: OIDC/LDAP settings now refetched after save so a first-time-configured provider reflects enabled immediately (matches React). 708 vitest passing; IntegrationsPage 94.36% lines; vue-tsc + vite 8 build clean; anti-slop clean. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 2, 2026
detain
added a commit
that referenced
this pull request
Jun 4, 2026
- Rename placeholder/index.ts to Placeholder.vue - Fix Vue SFC default export imports - Fix LibraryQueryParams interface - Add jsdom and @vue/test-utils devDependencies - Fix test setup
detain
added a commit
that referenced
this pull request
Jun 4, 2026
Port the deleted React IntegrationsPage into @phlix/ui as AdminIntegrationsPage, consolidating the React arrSync + authProviders (OIDC/LDAP) modules into one AdminIntegrationsApi (src/api/admin/integrations.ts). Arr-sync status + manual trigger (30s timeout toast) + auto-sync toggle; per-provider enable/disable; OIDC + LDAP config modals (LDAP host/port/ssl/base_dn/bind_dn/bind_pw with masking + omit-blank-to-keep + test-connection). Wired into the admin route/menu seam (admin-integrations); exported. Reviewer finding #2 fixed: OIDC/LDAP settings now refetched after save so a first-time-configured provider reflects enabled immediately (matches React). 708 vitest passing; IntegrationsPage 94.36% lines; vue-tsc + vite 8 build clean; anti-slop clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm installsucceedsnpm run buildproduces dist/tsc --noEmitpasses (vue-tsc)vitest runruns (no tests yet)Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com