Skip to content

Address PR review feedback: enhance error handling and fix redundant logic#266

Merged
devakesu merged 2 commits into1.4.7from
copilot/sub-pr-264
Feb 5, 2026
Merged

Address PR review feedback: enhance error handling and fix redundant logic#266
devakesu merged 2 commits into1.4.7from
copilot/sub-pr-264

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Addresses review feedback from PR #264 to improve error handling robustness and eliminate redundant conditional logic.

Changes

  • Enhanced connection error handling in save-token route

    • Added ECONNREFUSED to network error code list alongside existing codes (ETIMEDOUT, ENOTFOUND, EHOSTUNREACH, etc.)
    • Ensures consistent "service unavailable" responses for all connection failures
  • Simplified auth error detection in Supabase middleware

    • Removed duplicate 'invalid'/'expired' checks in nested token condition
    • Outer-level conditions already capture these cases
  • Glob dependency note

    • Review suggested updating to 13.2.0, but npm registry shows 13.0.1 is latest
    • Current version is correct; no changes needed
// Before: Missing ECONNREFUSED
if (isAxiosError(err) && err.code && 
    ['ECONNABORTED', 'ETIMEDOUT', 'ENOTFOUND', 'EHOSTUNREACH', 'ECONNRESET', 'ENETUNREACH'].includes(err.code))

// After: Complete connection error coverage
if (isAxiosError(err) && err.code && 
    ['ECONNABORTED', 'ETIMEDOUT', 'ENOTFOUND', 'EHOSTUNREACH', 'ECONNRESET', 'ENETUNREACH', 'ECONNREFUSED'].includes(err.code))

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…hecks

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dependencies and improve error handling Address PR review feedback: enhance error handling and fix redundant logic Feb 5, 2026
Copilot AI requested a review from devakesu February 5, 2026 20:28
@devakesu devakesu marked this pull request as ready for review February 5, 2026 20:28
Copilot AI review requested due to automatic review settings February 5, 2026 20:28
@devakesu devakesu merged commit 858607a into 1.4.7 Feb 5, 2026
@devakesu devakesu deleted the copilot/sub-pr-264 branch February 5, 2026 20:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses review feedback from PR #264 by refining error handling and removing redundant logic. The changes enhance the robustness of connection error handling in the authentication flow and simplify the token error detection logic in middleware by eliminating duplicate checks.

Changes:

  • Added ECONNREFUSED to network error code handling in save-token route for comprehensive connection failure coverage
  • Removed redundant 'invalid' and 'expired' checks from nested token condition in Supabase middleware, as these are already caught by outer-level checks

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/app/api/auth/save-token/route.ts Added ECONNREFUSED to the list of handled network error codes for more complete connection error coverage
src/lib/supabase/middleware.ts Simplified auth error detection by removing redundant 'invalid' and 'expired' checks from nested token condition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

devakesu added a commit that referenced this pull request Feb 6, 2026
* chore: update dependencies and improve error handling

- Updated package dependencies in package.json:
  - Upgraded @redocly/cli from ^1.31.0 to 2.15.1
  - Upgraded jsdom from ^27.4.0 to 28.0.0
  - Added glob as a dependency with version ^13.0.1
  - Added node-domexception as a dependency with version ^2.0.2
  - Added source-map as a dependency with version ^0.8.0-beta.0

- Increased timeout for authentication service requests from 5s to 15s in save-token route to handle slow backends and network latency.
- Enhanced error handling for connection issues in save-token route, logging specific error codes and providing user-friendly messages.
- Added conditional service worker registration in development mode based on ENABLE_SW_IN_DEV environment variable.
- Improved session management in Supabase middleware by clearing invalid session cookies when token refresh fails and logging the error.

* Address PR review feedback: improve error handling and dependency management (#265)

* Initial plan

* fix: address PR review feedback on error handling and dependencies

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* refactor: optimize middleware error detection

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Address PR review feedback: enhance error handling and fix redundant logic (#266)

* Initial plan

* Address PR review: add ECONNREFUSED error code and remove redundant checks

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Address review feedback: safe error handling and remove deprecated dependency (#267)

* Initial plan

* fix: improve error handling and remove deprecated package

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Replace string-based error matching with structured error detection in middleware (#268)

* Initial plan

* Improve error handling with structured properties and add npm version requirement

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Optimize error handling: move constants to module scope and improve type safety

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Unify service worker environment variable to NEXT_PUBLIC_ENABLE_SW_IN_DEV (#269)

* Initial plan

* Fix environment variable inconsistency in service worker registration

- Check both ENABLE_SW_IN_DEV and NEXT_PUBLIC_ENABLE_SW_IN_DEV
- Prioritize ENABLE_SW_IN_DEV (matching next.config.ts) with NEXT_PUBLIC_ as fallback
- Update logger message to document both options for backwards compatibility

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Use consistent environment variable NEXT_PUBLIC_ENABLE_SW_IN_DEV in both config and component

- Update next.config.ts to use NEXT_PUBLIC_ENABLE_SW_IN_DEV instead of ENABLE_SW_IN_DEV
- Update comments in next.config.ts to reflect the correct variable name
- Simplify sw-register.tsx to only check NEXT_PUBLIC_ENABLE_SW_IN_DEV
- This ensures users only need to set one environment variable for both build-time and runtime SW control

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

* Fix environment variable documentation and glob version mismatch (#270)

* Initial plan

* Fix README and package.json per review feedback

Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: devakesu <61821107+devakesu@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants