Python 3.12+ Compatability#11
Open
BlastoiseBlue wants to merge 4 commits intodevcontainers-extra:mainfrom
Open
Python 3.12+ Compatability#11BlastoiseBlue wants to merge 4 commits intodevcontainers-extra:mainfrom
BlastoiseBlue wants to merge 4 commits intodevcontainers-extra:mainfrom
Conversation
Invoke 2.1.0 is the earliest version that uses `importlib` instead of `imp`, and by extension, is the first version to support python 3.12+
Click version `8.0.0` includes a backwards-incompatible change that prevents nanolayer from working, so I'm pinning it to a version that should still work.
`distutils` was removed in Python 3.12. The use of `distutils.spawn.find_executable()` can be replaces with `shutil.which()` for the same result.
Pydantic version 1.10.7 is incompatible with python 3.14. Support for python 3.14 is available in version 1.10.25, so relaxing the upper bound should allow nanolayer to continue running on python 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have adjusted the pinned version of Invoke to a version that uses importlib instead of
imp, pinned click to a version that doesn't raise an exception, and replaced the usage of distutils with shutil, in order to make the nanolayer library compatible with python 3.12+Closes #10