Kyle/globe reprojector#578
Draft
kylebarron wants to merge 6 commits into
Draft
Conversation
Design for replacing the throwaway uniform-grid globe mesh with a GlobeReprojector subclass that adds a curvature (sag) term to Delatin's refinement metric. Lives in deck.gl-raster; raster-reproject gains behavior-preserving extensibility seams only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#574 extracted _seed(InitialTriangulation) but keeps it eager in the constructor. Update the spec to keep eager seeding and absorb the init-order hazard in the GlobeReprojector subclass (renderPositions ??= guard + run()'s _reevaluate), shrinking base changes to three protected edits. Drop the run() options-object refactor: the globe overrides the existing run(maxError, { maxIterations }) compatibly by adding sagTolerance to the options bag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Routes the per-sample reprojection error through a protected _sampleError hook (default returns the pixel error, so behavior is unchanged) and makes _addPoint protected. Foundation for GlobeReprojector's sag metric. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Protected hook that clears the priority queue and re-runs the scoring seam over every triangle. For subclasses whose _sampleError depends on run-time inputs (GlobeReprojector's tolerances); the base never calls it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… kyle/globe-reprojector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design for replacing the throwaway uniform-grid globe mesh with a
GlobeReprojector subclass that adds a curvature (sag) term to Delatin's
refinement metric. Lives in deck.gl-raster; raster-reproject gains
behavior-preserving extensibility seams only.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com