fix: Support parsing ESRI WKT String for ESRI-created custom CRS#579
Merged
Conversation
Member
Author
|
The image still doesn't render but this is a valid improvement (with a test), so we can move the rendering question to the next branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref source-cooperative/cog-viewer#8 and developmentseed/geotiff-test-data#58 and developmentseed/async-geotiff#165. This GeoTIFF includes
GeoTIFF has
model_type,geographic_type,projected_typegeokeys.model_typeis 1, check theprojected_typeprojected_typeis an int < 32767, it's an EPSG code; else CRS encoded in GeoKeysmodel_typeis 2, check thegeographic_typegeographic_typeis an int < 32767, it's an EPSG code; else CRS encoded in GeoKeysmodel_typeis 32767, then the projection is "undefined", and there's a (hack? grandfathered?) way that uses ESRI WKT in the proj citation key.This PR now supports the latter approach when
model_typeitself is 32767.