fix: reverse date and display bug #427
Open
+13
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
requested changes
Dec 9, 2025
live-demo/app/custom/Dashboard.vue
Outdated
| unlistedPrice: item.unlistedPrice.toFixed(2), | ||
| }) | ||
| ); | ||
| const arr = data.value?.listedVsUnlistedPriceByDays; |
Contributor
There was a problem hiding this comment.
Instead of this fix lets simply return data in correct order from backend , by modifying query (this is live demo so this is crucial to keep code simple)
ivictbor
requested changes
Dec 9, 2025
live-demo/app/index.ts
Outdated
| LIMIT ?; | ||
| ` | ||
| ).all(days); | ||
| apartsByDays.reverse(); |
ivictbor
requested changes
Dec 10, 2025
live-demo/app/index.ts
Outdated
| COUNT(*) as count | ||
| FROM apartments | ||
| GROUP BY day | ||
| ORDER BY day DESC |
ivictbor
requested changes
Dec 15, 2025
live-demo/app/index.ts
Outdated
| const days = req.body.days || 7; | ||
| const apartsByDays = await db.prepare( | ||
| `SELECT | ||
| `SELECT |
Contributor
There was a problem hiding this comment.
@tesaide please return whitespaces back
Correct formatting:
const x = function doThis(
aa=1,
bb=2
)
Bad formatting
const x = function doThis(
aa=1, // reads really hard, it is hard to distinguish
bb=2
)
live-demo/app/index.ts
Outdated
| ORDER BY day ASC | ||
| LIMIT ?;` | ||
| ).all(days); | ||
|
|
Contributor
There was a problem hiding this comment.
@tesaide I think there is no sense to add a new empty line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.