Fix lust assignment bugs causing teams to be silently dropped#12
Merged
Conversation
When a healer captain was present (including stale captain flags persisted in session storage), the lust fallback could assign a same-role healer provider, giving the team 6 members instead of 5 and causing it to fail the length check silently. Additionally, multi-spec lust players could appear on multiple teams due to stale entries in the providers list, and their DPS entry being selected could deplete the healer pool. - Remove lust fallback that forced conflicting same-role providers - Deduplicate lust providers by player, preferring healer entries to prevent healer pool depletion with multi-spec selections - Enable captain logging to surface stale captain flags from session storage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying mythic-plus-team-randomiser with
|
| Latest commit: |
8df20e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc2373b0.mythic-plus-team-randomiser.pages.dev |
| Branch Preview URL: | https://fix-lust-assignment-bugs.mythic-plus-team-randomiser.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captain: trueflags persisted in session storage), the lust fallback forced a same-role healer provider onto the team, giving it 6 members instead of 5 — silently dropped by thelength === 5checkavailableLustProviders, and selecting their DPS entry would deplete the healer pool (viapruneWorkingMembersremoving all entries by name+realm)Changes
providerIndex = 0whenfindIndexreturned -1)availableLustProvidersby player using a Map keyed onname-realm, preferring healer entries so lust fills both the lust and healer slotTest plan
🤖 Generated with Claude Code