fix(redfish): fixed failures on redfish protocol validator by DevipriyaS17 · Pull Request #823 · device-management-toolkit/console

DevipriyaS17 · 2026-03-05T08:31:27Z

Added /redfish version endpoint
Fixed OData service context and header validation
Enhanced response headers (Link, Allow, WWW-Authenticate)
Removed single-session-per-user restriction
Added POST to /SessionService/Sessions/Members

Fixed 17 of 20 DMTF Protocol Validator failures.

Results
FAIL: 20 → 3

codecov · 2026-03-05T08:56:38Z

Codecov Report

❌ Patch coverage is 28.64583% with 137 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (redfish@5ca1b5d). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...nternal/controller/http/v1/generated/server.gen.go	0.00%	65 Missing ⚠️
internal/usecase/devices/interceptor.go	2.00%	49 Missing ⚠️
redfish/component.go	22.22%	7 Missing ⚠️
internal/usecase/devices/power.go	82.14%	3 Missing and 2 partials ⚠️
...fish/internal/controller/http/v1/handler/errors.go	84.37%	5 Missing ⚠️
...nternal/controller/http/v1/handler/service_root.go	20.00%	4 Missing ⚠️
...sh/internal/controller/http/v1/handler/sessions.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             redfish     #823   +/-   ##
==========================================
  Coverage           ?   34.17%           
==========================================
  Files              ?      135           
  Lines              ?    14237           
  Branches           ?        0           
==========================================
  Hits               ?     4865           
  Misses             ?     8937           
  Partials           ?      435

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sudhir-intc · 2026-03-09T03:43:10Z

redfish/component.go

 		Middlewares:  middlewares,
 	})

+	// Register /redfish endpoint manually (required by Redfish protocol)


Is this the right way to add or should it be updated in the spec so that the code gets generated automatically.

updated via specs

sudhir-intc · 2026-03-09T03:43:42Z

redfish/component.go

+
+	// Per Redfish spec: POST to collection/Members is equivalent to POST to collection
+	// Add this route to support protocol validator requirements
+	router.POST("/redfish/v1/SessionService/Sessions/Members", server.PostRedfishV1SessionServiceSessions)


Same as the previous comment.
Is this the right way to add or should it be updated in the spec so that the code gets generated automatically.

updated via specs

redfish/internal/controller/http/v1/handler/service_root.go

…oint and computer system boot

sudhir-intc · 2026-03-16T07:47:23Z

config/config_test.go

 	clearEnv() // Clear environment variables before setting new ones

 	// Create a temporary config file
+	//nolint:gosec // Test fixture with dummy credentials


Changes like this which are not redfish specific need to be fixed on main

sudhir-intc · 2026-03-16T07:47:50Z

internal/controller/httpapi/v1/devices_test.go

 			var err error

 			if tc.method == http.MethodPost || tc.method == http.MethodPatch {
+				//nolint:gosec // Test fixture marshaling request body with test credentials


Changes like this which are not redfish specific need to be fixed on main

sudhir-intc · 2026-03-16T07:47:56Z

internal/controller/httpapi/v1/ciraconfigs_test.go

 			var err error

 			if tc.method == http.MethodPost || tc.method == http.MethodPatch {
+				//nolint:gosec // Test fixture marshaling request body with test credentials


Changes like this which are not redfish specific need to be fixed on main

sudhir-intc · 2026-03-16T07:48:59Z

internal/controller/httpapi/v1/kvm_test.go

 		deviceManagement.EXPECT().GetKVMScreenSettings(context.Background(), "guid1").Return(dto.KVMScreenSettings{Displays: []dto.KVMScreenDisplay{{DisplayIndex: 0, IsActive: true}}}, nil)

-		req := httptest.NewRequest(http.MethodGet, "/api/v1/amt/kvm/displays/guid1", http.NoBody)
+		req := httptest.NewRequestWithContext(context.Background(), http.MethodGet, "/api/v1/amt/kvm/displays/guid1", http.NoBody)


Changes like this which are not redfish specific need to be fixed on main

sudhir-intc · 2026-03-16T07:50:54Z

redfish/internal/controller/http/v1/handler/middleware_test.go

 			})

-			req := httptest.NewRequest(http.MethodGet, "/test", http.NoBody)
+			req := httptest.NewRequestWithContext(context.Background(), http.MethodGet, "/test", http.NoBody)


This change why is it needed, its not there on main ?

sudhir-intc · 2026-03-16T07:51:28Z

redfish/internal/controller/http/v1/handler/service_root.go


+// GetRedfish handles GET /redfish
+// Returns protocol version information. Must be publicly accessible without authentication.
+func (s *RedfishServer) GetRedfish(c *gin.Context) {


Is this still needed?

DevipriyaS17 linked an issue Mar 5, 2026 that may be closed by this pull request

[Redfish] Resolve issues in the Redfish protocol validator tests #822

Open

DevipriyaS17 force-pushed the redfish_protocol_fix branch 2 times, most recently from 1600a7d to 7270d18 Compare March 5, 2026 08:52

fix(redfish): fixed failures on redfish protocol validator

7270d18

DevipriyaS17 marked this pull request as ready for review March 6, 2026 05:03

DevipriyaS17 requested review from nmgaston and sudhir-intc March 6, 2026 05:04

sudhir-intc reviewed Mar 9, 2026

View reviewed changes

DevipriyaS17 added 2 commits March 13, 2026 11:41

fix(redfish): generated api file for redfish and session members endp…

f020e77

…oint and computer system boot

fix: fixed lint issues

6c6db83

sudhir-intc requested changes Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(redfish): fixed failures on redfish protocol validator#823

fix(redfish): fixed failures on redfish protocol validator#823
DevipriyaS17 wants to merge 3 commits intoredfishfrom
redfish_protocol_fix

DevipriyaS17 commented Mar 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

sudhir-intc Mar 9, 2026

Uh oh!

DevipriyaS17 Mar 13, 2026

Uh oh!

sudhir-intc Mar 9, 2026

Uh oh!

DevipriyaS17 Mar 13, 2026

Uh oh!

Uh oh!

sudhir-intc Mar 16, 2026 •

edited

Loading

Uh oh!

sudhir-intc Mar 16, 2026 •

edited

Loading

Uh oh!

sudhir-intc Mar 16, 2026 •

edited

Loading

Uh oh!

sudhir-intc Mar 16, 2026 •

edited

Loading

Uh oh!

sudhir-intc Mar 16, 2026

Uh oh!

sudhir-intc Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

DevipriyaS17 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sudhir-intc Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

DevipriyaS17 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

DevipriyaS17 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sudhir-intc Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

sudhir-intc Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DevipriyaS17 commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited

Loading

sudhir-intc Mar 16, 2026 •

edited

Loading

sudhir-intc Mar 16, 2026 •

edited

Loading

sudhir-intc Mar 16, 2026 •

edited

Loading

sudhir-intc Mar 16, 2026 •

edited

Loading