Fix plot_perturbation to ensure nbl is not plotted#2797
Open
cako wants to merge 6 commits intodevitocodes:mainfrom
Open
Fix plot_perturbation to ensure nbl is not plotted#2797cako wants to merge 6 commits intodevitocodes:mainfrom
cako wants to merge 6 commits intodevitocodes:mainfrom
Conversation
Fix plotting of nbl
EdCaunt
reviewed
Dec 1, 2025
Contributor
EdCaunt
left a comment
There was a problem hiding this comment.
Minor comment, but generally a useful fix. Thanks!
EdCaunt
reviewed
Jan 6, 2026
mloubout
reviewed
Jan 7, 2026
EdCaunt
approved these changes
Jan 12, 2026
Contributor
EdCaunt
left a comment
There was a problem hiding this comment.
I'm happy with this once CI is green
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
- Coverage 78.97% 78.96% -0.01%
==========================================
Files 248 248
Lines 50936 50938 +2
Branches 4404 4404
==========================================
- Hits 40226 40224 -2
- Misses 9909 9912 +3
- Partials 801 802 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
approved these changes
Jan 12, 2026
Author
|
@EdCaunt seems like the linting is failing elsewhere: |
Contributor
|
@cako can you check this is rebased on latest Note that the first line is only a warning. |
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
plot_perturbationhas a small bug where the nbl is not properly addressed when plotting. This PR addressed that by applying the same slicing asplot_velocity.