Skip to content

fix: prevent transitive ThisAssembly.Constants deps from copying assemblies to output #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 2 commits into from
Jun 24, 2026
Merged

fix: prevent transitive ThisAssembly.Constants deps from copying assemblies to output #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ededccb
fix: prevent transitive ThisAssembly.Constants deps from copying asse…
kzu Jun 24, 2026
1da6445
fix: use 'dotnet dnx' for portable invocation in CI test steps
kzu Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:

- name: 🧪 test
shell: pwsh
run: dnx --yes retest -- --no-build
run: dotnet dnx --yes retest -- --no-build

- name: 🐛 logs
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

- name: 🧪 test
shell: pwsh
run: dnx --yes retest -- --no-build
run: dotnet dnx --yes retest -- --no-build

- name: 🐛 logs
uses: actions/upload-artifact@v4
Expand Down
6 changes: 6 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

:bug: Fixed bugs:

- Assemblies of transitive nuget dependencies are placed into the build folder [\#389](https://github.com/devlooped/GitInfo/issues/389)

## [v3.6.0](https://github.com/devlooped/GitInfo/tree/v3.6.0) (2025-10-17)

[Full Changelog](https://github.com/devlooped/GitInfo/compare/v3.6.0-beta...v3.6.0)
Expand Down
2 changes: 1 addition & 1 deletion src/GitInfo/GitInfo.msbuildproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ItemGroup>
<PackageReference Include="NuGetizer" Version="1.4.5" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
<PackageReference Include="ThisAssembly.Constants" Version="2.1.2" Pack="true" TargetFramework="netstandard2.0" />
<PackageReference Include="ThisAssembly.Constants" Version="2.1.2" Pack="true" PrivateAssets="all" IncludeAssets="build;analyzers" TargetFramework="netstandard2.0" />
</ItemGroup>
<ItemGroup>
<None Include="build/**/*.*" />
Expand Down
3 changes: 3 additions & 0 deletions src/GitInfo/buildMultiTargeting/GitInfo.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
<!-- Make sure we're always private to the referencing project. Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="GitInfo" PrivateAssets="all" PackTransitive="false" />

<!-- Ensure ThisAssembly.Constants (a dependency) is only used for build/analyzers to avoid bringing its transitive runtime assemblies (e.g. System.Threading.Tasks.Extensions.dll, System.Runtime.CompilerServices.Unsafe.dll) into the build output. See https://github.com/devlooped/GitInfo/issues/389 -->
<PackageReference Update="ThisAssembly.Constants" PrivateAssets="all" IncludeAssets="build;analyzers" />

<!-- This makes sure we don't enforce SponsorLink transitively, but only when consumers are directly referencing our package. -->
<SponsorablePackageId Include="GitInfo" />

Expand Down
3 changes: 3 additions & 0 deletions src/GitInfo/buildTransitive/GitInfo.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
<!-- Make sure we're always private to the referencing project. Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="GitInfo" PrivateAssets="all" PackTransitive="false" />

<!-- Ensure ThisAssembly.Constants (a dependency) is only used for build/analyzers to avoid bringing its transitive runtime assemblies (e.g. System.Threading.Tasks.Extensions.dll, System.Runtime.CompilerServices.Unsafe.dll) into the build output. See https://github.com/devlooped/GitInfo/issues/389 -->
<PackageReference Update="ThisAssembly.Constants" PrivateAssets="all" IncludeAssets="build;analyzers" />

<!-- This makes sure we don't enforce SponsorLink transitively, but only when consumers are directly referencing our package. -->
<SponsorablePackageId Include="GitInfo" />

Expand Down
Loading