fix: ai view issues #2987
fix: ai view issues #2987
Conversation
feat: add validation for reserved output directory path
fix(css): Source Info card container
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
feat: update navigation href
|
… chore/sync-main-dev-12-11
chore: sync-main
…nto feat/scan-cve-listing
feat: scan CVE listing
chore: update common-lib
chore: final backup with common update
chore: Kubecon 2025
…nto fix/ai-fixes
…types, and update feature visibility.
…avigationList` function and `filterNavGroupAndItem` utility.
feat: Reimplement navigation component, remove legacy styles and types, and update feature visibility
…ionList` and remove redundant filtering from `Navigation.tsx`.
feat: Filter navigation groups and their sub-items
…and introduce a generic filter empty state.
chore: Consolidate workflow creation buttons into a single method …
…nto fix/ai-fixes
|
There was a problem hiding this comment.
Pull request overview
This pull request refactors the navigation and security center architecture by removing the "AI Recommendations" section and reorganizing security-related features. Key changes include adding "Runbook Automation" under "Automation & Enablement", restructuring the Security Center with new "Vulnerabilities" and "Security Enablement" sections, updating the common library dependency, and comprehensive code cleanup across navigation, security, and various UI components.
- Removes "AI Recommendations" navigation group and related routes
- Adds "Runbook Automation" navigation item and "Vulnerabilities" section in Security Center
- Updates
@devtron-labs/devtron-fe-common-libfrom1.20.6-pre-45to1.21.0-pre-2
Reviewed changes
Copilot reviewed 92 out of 96 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Navigation/constants.ts | Removes AI Recommendations group, adds Runbook Automation item, restructures security navigation |
| Navigation/types.ts | Simplifies navigation type definitions, removes unused properties |
| Navigation/Navigation.tsx | Updates to use dynamic navigation list based on server mode |
| NavigationRoutes.tsx | Removes AuditLog import, updates feature flags, adds AIRecommendations import |
| security/Security.tsx | Replaces SecurityScansTab with VulnerabilitiesRouter |
| security/Vulnerabilities/* | New vulnerability management components and services |
| security/SecurityScansTab/* | Major refactoring to support scanned/not-scanned views |
| package.json | Updates version and common library dependency |
| .env | Renames feature flags for consistency |
| yarn.lock | Updates dependency lockfile |
| Multiple component files | UI improvements, component migrations (RadioGroup to SegmentedControl), styling updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { CVE_LIST_TABLE_COLUMNS } from './constants' | ||
| import CVETableWrapper from './CVEListTableWrapper' | ||
| import { getCVEList } from './service' | ||
| import { CVEDetails } from './types' |
There was a problem hiding this comment.
Unused import CVEDetails.
| <div | ||
| data-testid="security-vulnerability-card" | ||
| className={`app-details-info-card flex left bg__primary br-8 mr-12 lh-20 w-200 ${cardLoading || scanResultError ? '' : 'pointer'}`} | ||
| className={`app-details-info-card flex left bg__primary br-8 lh-20 w-200 ${cardLoading || scanResultError ? '' : 'pointer'}`} |
There was a problem hiding this comment.
This use of variable 'cardLoading' always evaluates to false.
Description
This pull request updates navigation and routing to remove the "AI Recommendations" section from the sidebar and its related routes, while adding a new "Runbook Automation" navigation item under "Automation & Enablement". It also includes minor dependency updates and code cleanup for navigation components.
Navigation Structure Updates:
COMMON_URLS.AUTOMATION_ENABLEMENT_RUNBOOKS. [1] [2]Routing and Component Integration:
AIRecommendationscomponent for future use. [1] [2] [3]Code Cleanup and Dependency Update:
@devtron-labs/devtron-fe-common-libdependency to version1.20.6-pre-46inpackage.json.NavItem.tsx. [1] [2] [3]AuditLogfrom navigation constants.Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: