test(writer): cover PatchedEncodingEncoder narrow-width + error paths#57
Merged
Conversation
Add tests exercising every integer PType through toLongs/fromLongs/PTypeIO.set, the non-primitive and unsupported-ptype throw paths, and the no-bit-width-gain notApplicable branch. Coverage on PatchedEncodingEncoder goes from 42 missed lines to 1 (an unreachable defensive default in fromLongs). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dfa1
force-pushed
the
test/patched-encoder-coverage
branch
from
05e19e0 to
a9bda35
Compare
runAndAwait waited on a signal raised in the task's finally, while pending was decremented later in submit's own finally — so a caller reading pending() right after runAndAwait returned could still see the task counted. Replace the signal with a CountDownLatch counted down after the decrement, making the decrement happen-before the await returns. Also bail out early when closed, matching submit and avoiding an indefinite wait on a closed worker. Fixes flaky IoWorkerTest.pending_isZeroAfterTaskCompletes (reproduced on CI). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests exercising every integer PType through toLongs/fromLongs/PTypeIO.set,
the non-primitive and unsupported-ptype throw paths, and the no-bit-width-gain
notApplicable branch. Coverage on PatchedEncodingEncoder goes from 42 missed
lines to 1 (an unreachable defensive default in fromLongs).
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com