fix(cli): close handle on all error paths, return Optional from openOnWorker#59
Merged
Conversation
…nWorker ViewCommand leaked the opened VortexHandle if anything threw between opening it and entering the grid-source try block (Sonar S2095, BLOCKER → reliability E): the close lived only in the inner try's finally. Wrap every post-open step in a try/finally that closes the handle on the worker thread. CliHandles.openOnWorker now returns Optional<VortexHandle> instead of null, and ViewCommand/TuiCommand branch on isEmpty(). The null sentinel made Sonar flag the missing-file guards as always-false (S2583) because it lost dataflow across the runAndAwait lambda; Optional both removes the smell and is idiomatic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewCommand leaked the opened VortexHandle if anything threw between opening it
and entering the grid-source try block (Sonar S2095, BLOCKER → reliability E):
the close lived only in the inner try's finally. Wrap every post-open step in a
try/finally that closes the handle on the worker thread.
CliHandles.openOnWorker now returns Optional instead of null, and
ViewCommand/TuiCommand branch on isEmpty(). The null sentinel made Sonar flag
the missing-file guards as always-false (S2583) because it lost dataflow across
the runAndAwait lambda; Optional both removes the smell and is idiomatic.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com