Ensure DATABRICKS_HOST starts with https for API calls#140
Draft
cjrace wants to merge 3 commits into
Draft
Conversation
… to utils.R; clarify docs; add tests; lint fixes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 57.19% 57.04% -0.15%
==========================================
Files 18 18
Lines 1509 1532 +23
==========================================
+ Hits 863 874 +11
- Misses 646 658 +12 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Disclaimer, used GitHub Copilot's agent mode locally in Positron to raise this, wanted to test how well it could autonomously pick up an issue and raise a fix - it wasn't as smooth as Claude Code, and GPT-4.1 definitely feels a step down from the latest other models, but seems like there's some potential here]
Brief overview of changes:
Why are these changes being made?
To resolve issue #139 and ensure robust, user-friendly handling of Databricks host configuration.
Checklist
Issue ticket number and link
Fixes #139
Additional info - prompts used
I didn't have gh CLI installed for it to raise the PR itself, so I've done that here using the text outputted in the chat pane (with the addition of the prompts for sight).
After the initial PR I did then go away and fix it up myself, including undoing additional styling changes beyond the scope of this PR.