docs(chain-fusion): diagram styling, KYT flows, and Bitcoin canister corrections#176
Merged
Merged
Conversation
- Darken ActorBorderColor from hairline (#e5ddcf) to muted (#6b6660) so the stick figure is visible against the parchment fill - Wrap diagram <img> in <figure class="plantuml-diagram"> for CSS targeting - Add .plantuml-diagram styles: elevated background, 6px radius, centered - Fix dark mode with filter: invert(1) hue-rotate(180deg) on the image; this flips luminance while preserving approximate hue relationships so arrows remain in the warm-red family
The bitcoin_* methods were moved from the management canister to the dedicated Bitcoin canisters (ghsi2-tqaaa-aaaan-aaaca-cai for mainnet, g4xu7-jiaaa-aaaan-aaaaq-cai for testnet). The management canister bitcoin_* API is deprecated (documented in management-canister.md). - bitcoin.mdx: replace "management canister" with "Bitcoin canister" in the two prose references to the direct Bitcoin API - bitcoin.mdx: update management canister Next steps link to clarify bitcoin_* methods are deprecated there; signing (sign_with_ecdsa, sign_with_schnorr) still uses the management canister - dogecoin.md: fix comparison table (Management canister -> Bitcoin canister) and three prose references that incorrectly named the management canister
…sibility ParticipantBorderColor and NoteBorderColor were #e5ddcf (hairline). After invert(1) hue-rotate(180deg) in dark mode, both the box fill (#fdfaf3 -> near-black) and the border (#e5ddcf -> also near-black) inverted to nearly the same tone, making participant boxes invisible. Changed both to #6b6660 (muted), consistent with lifeline and actor border colors. After inversion this becomes ~#94999f (light gray), clearly visible against the dark-inverted participant fill.
…rams Deposit diagram: add Bitcoin Checker (KYT), ckBTC Ledger, and a note about the 6-confirmation requirement. The simplified diagram omitted the KYT compliance check which can quarantine UTXOs, and the Ledger as the minting endpoint. Withdrawal diagram: add Bitcoin Checker (KYT) for destination address validation and an async note for the batched Bitcoin submission. Prose: updated to name the 6-confirmation threshold, the 100-satoshi KYT fee per UTXO, quarantine behaviour, and the retrieve_btc_status_v2 call for tracking withdrawal status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #174. Changes that were not pushed before that PR was merged.
PlantUML diagram styling (
plugins/remark-plantuml.mjs,src/styles/custom.css):<figure class="plantuml-diagram">for CSS targeting--icp-bg-elev) andborder-radius: 6pxas visual container (no explicit border needed)filter: invert(1) hue-rotate(180deg)on the image preserves hue relationships while flipping luminance#e5ddcf) to muted (#6b6660) so all structural lines remain legible after dark mode inversionBitcoin canister corrections (
bitcoin.mdx,dogecoin.md):bitcoin_*API callsmanagement-canister.mdsign_with_ecdsa/sign_with_schnorr, which do stay on the management canisterckBTC flow diagrams (
bitcoin.mdx):retrieve_btc_status_v2for withdrawal trackingConfirmation count (
bitcoin.mdx,chain-key-tokens.mdx):chain-key-tokens.mdxcallout (distinct from the table/description already updated in fix(ckbtc): update min_confirmations from 6 to 4 #173)Sync recommendation
informed by dfinity/ic rs/bitcoin/ckbtc/minter/README.adoc; dfinity/bitcoin-canister INTERFACE_SPECIFICATION.md; wiki.internetcomputer.org/wiki/Chain-key_Bitcoin