docs: chain-key cryptography concept page#20
Conversation
- Move periodic key resharing from Chain Evolution to DKG section (core protocol, not just evolution) - Add evergreen framing to deployed keys table (note NNS can change, link to dashboard) - Clarify chain-fusion guide link text (no index page exists)
marc0olo
left a comment
There was a problem hiding this comment.
Review: Chain-Key Cryptography
Must fix
-
EdDSA framing as a third signature scheme. The PR lists three schemes in the table header: "Threshold ECDSA", "Threshold Schnorr (BIP340)", and "Threshold Schnorr (Ed25519)". The opening paragraph also says "threshold ECDSA, Schnorr, and EdDSA signatures." However, the portal source (
t-sigs-how-it-works.mdx:9) states ICP supports threshold ECDSA and threshold Schnorr — two schemes, not three. Ed25519 is an algorithm within the Schnorr API (schnorr_public_key,sign_with_schnorr), not a separate scheme with its own API. The "Chain-key signatures" section and table should reflect this: two schemes (ECDSA + Schnorr), with Schnorr supporting two algorithms (BIP340 and Ed25519). -
Cardano missing Schnorr in supported chains table. The PR lists Cardano as "ECDSA, EdDSA" but the portal source (
supported-chains.mdx:77) lists "ECDSA, EdDSA, Schnorr". -
Missing Ethereum guide cross-link. The stub's
<!-- Cross-Links -->specifiesguides/chain-fusion/ethereum, and the file exists. The "What's next" section only links to Bitcoin via the Chain Fusion concept page but doesn't mention the Ethereum guide directly. Since ECDSA is the primary scheme for Ethereum integration, a direct link would be valuable.
Suggestions
-
Missing chains from the supported chains table. The portal source lists several chains not in the PR table: Aptos, Avalanche, Hedera, Kaspa, Monero, Stacks, Sui, TRON, XRP. The PR says "this is not exhaustive" which is fair, but some notable omissions (XRP, Avalanche, TRON — all top-20 chains) could be worth including for completeness. At minimum, consider adding them since the portal already lists them.
-
"key management across subnets" coverage is thin. The content brief asks about key management across subnets. The DKG section mentions key resharing briefly, and the "Deployed keys" table mentions signing subnets, but the concept of backup subnets (the portal says each key is deployed on two subnets — one for signing, one for backup) isn't explained. Adding a sentence about this would improve coverage.
-
Learn Hub link at bottom is vague. The chain evolution section ends with "see the Learn Hub" — a generic link with no specific article. The stub lists specific Learn Hub articles (Chain Evolution:
34210120121748). Either link to the specific article or drop the link entirely. -
"fast finality" in frontmatter description. The description says "fast finality" but the page doesn't discuss finality — it discusses fast verification. Consider aligning the description with the actual content.
Verified
- All 9 internal links resolve to existing files (
network-overview.md,certified-variables.md,onchain-randomness.md,chain-fusion.md,management-canister.md,ic-interface-spec.md,cycles-costs.md,vetkeys.md,bitcoin.md) - API method names (
ecdsa_public_key,sign_with_ecdsa,schnorr_public_key,sign_with_schnorr) verified against portal source - 6 deployed master keys verified against portal source
- Key derivation description (BIP-32 for ECDSA/BIP340, custom for Ed25519) verified
- DKG fault tolerance ("up to one-third") verified
- BIP340/Schnorr/Taproot terminology verified
- No
dfxreferences, no.mdx/JSX, code is prose-only (appropriate for concept page), frontmatter complete - Diataxis: concept page — explains "what" and "why" without CLI commands or step-by-step instructions ✓
- Content brief coverage: threshold ECDSA ✓, threshold Schnorr ✓, BLS ✓, chain evolution ✓, developer perspective ✓, supported chains table ✓
- Fix EdDSA framing: two schemes (ECDSA + Schnorr), not three - Fix supported chains intro to reflect correct Schnorr taxonomy - Correct Cardano (Ed25519 only), Cosmos (ECDSA only) signature schemes - Normalize Bitcoin/Dogecoin integration method to "Direct" - Add 7 verified chains: Aptos, Avalanche, Hedera, Stacks, Sui, TRON, XRP - Drop Monero (incompatible ring sigs) and Kaspa (unverified BIP-340) - Add Ethereum guide cross-link to What's next - Add backup subnet availability note to Deployed keys - Link to specific Chain Evolution Learn Hub article - Fix frontmatter description: "fast finality" → "fast verification"
|
Feedback addressed:
|
Summary
Sync recommendation
informed by dfinity/portal docs/references/t-sigs-how-it-works.mdx, docs/building-apps/chain-fusion/overview.mdx, docs/building-apps/chain-fusion/supported-chains.mdx