fix(security): apply ICP brand voice to security guides#234
Merged
Conversation
- Replace all standalone "dapp"/"dapps" with "app"/"apps" across 9 files; preserve repo names (nns-dapp, encrypted-notes-dapp) in URLs and update their link labels (NNS app, encrypted notes example app) - Replace "smart contract(s)" with "canister(s)" in decentralization.md, including section heading and the blockchains admonition note - Remove em-dashes from Upstream comments in all 11 remaining files (identity-and-access-management.mdx was already fixed) - Remove informal phrasing in data-integrity-and-authenticity.md: "club composite_query" and "best of both worlds" - Fix garbled sentence in identity-and-access-management.mdx mobile II section
…ion.md Aligns with wording convention established in PR #208 (SNS framework page), which avoids "DAO" in prose and uses "community-governed" constructions instead. - "Full decentralization using a DAO" heading -> "Full community governance" - "DAO evolves" link text -> "community governance evolves" - "building your own DAO" -> "building your own governance system" - "alternative to DAO control" -> "alternative to community governance" - "implement a DAO from scratch" -> "implement a custom governance canister" - "basic DAO example" link text -> "basic governance example" - "the DAO is controlled by itself" -> "the governance canister is controlled by itself"
… not "query call"
…mperproof Per updated brand voice rules: - offchain components -> external components/infrastructure (decentralization.md) - tamper-resistant -> tamperproof (observability-and-monitoring.md)
marc0olo
added a commit
that referenced
this pull request
May 12, 2026
## Summary - **\"dapp\"/\"dapps\" → \"app\"/\"apps\"** across all 12 security guide files; repository names in URLs preserved (`nns-dapp`, `encrypted-notes-dapp`), link labels updated (`NNS app`, `encrypted notes`) - **\"smart contract(s)\" → \"canister(s)\"** in `decentralization.md`, including the section heading and the blockchains admonition note - **Em-dashes removed from `<!-- Upstream: -->` comments** in all 11 remaining files (`identity-and-access-management.mdx` was already fixed in a previous commit) - **Informal phrasing removed** in `data-integrity-and-authenticity.md`: \"we will club composite_query\" and \"best of both worlds\" - **Garbled sentence fixed** in `identity-and-access-management.mdx` (mobile II section): the original had a sentence fragment mid-paragraph from a copy-paste error - **\"DAO\" removed from prose** in `decentralization.md`; replaced with \"community governance\", \"governance framework\", and \"custom governance canister\" following the convention established in PR #208 - **\"decentralized governance system\" → \"governance framework\"** throughout `decentralization.md` - **`composite_query` description corrected** in `data-integrity-and-authenticity.md`: \"query call\" → \"query methods\" (composite_query is a method type, not a call type) - **\"off-chain\" → \"offchain\" / \"external\"** in `decentralization.md`; bare \"onchain\"/\"offchain\" category labels replaced with descriptive terms (\"external components\", \"hosted as canisters\") - **\"tamper-resistant\" → \"tamperproof\"** in `observability-and-monitoring.md` (one word, per brand guide) - **\"on-chain\" → \"stored in the canister\"** in `observability-and-monitoring.md` ## Sync recommendation `informed by dfinity/portal` — content is derived from the portal source but diverges intentionally for brand voice compliance; no sync back to portal is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nns-dapp,encrypted-notes-dapp), link labels updated (NNS app,encrypted notes)decentralization.md, including the section heading and the blockchains admonition note<!-- Upstream: -->comments in all 11 remaining files (identity-and-access-management.mdxwas already fixed in a previous commit)data-integrity-and-authenticity.md: "we will club composite_query" and "best of both worlds"identity-and-access-management.mdx(mobile II section): the original had a sentence fragment mid-paragraph from a copy-paste errordecentralization.md; replaced with "community governance", "governance framework", and "custom governance canister" following the convention established in PR docs: migrate Learn Hub 'How does ICP work?' content into developer docs #208decentralization.mdcomposite_querydescription corrected indata-integrity-and-authenticity.md: "query call" → "query methods" (composite_query is a method type, not a call type)decentralization.md; bare "onchain"/"offchain" category labels replaced with descriptive terms ("external components", "hosted as canisters")observability-and-monitoring.md(one word, per brand guide)observability-and-monitoring.mdSync recommendation
informed by dfinity/portal— content is derived from the portal source but diverges intentionally for brand voice compliance; no sync back to portal is expected.